-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bank): Create message for Setting SendEnabled settings #11981
Conversation
…or getting, setting, and deleting them.
…cluded." This reverts commit 8b7acf8.
…roto." This reverts commit 0bd904c.
…oto." This reverts commit 33d4652.
…endEnabledCoins. Store creation has some overhead.
…ple TODO notes. Create a way to iterate over the SendEnabled entries and get all of them.
…ed entries similar to when they were params.
…unction significantlly simpler.
# Conflicts: # api/cosmos/bank/v1beta1/bank.pulsar.go # api/cosmos/bank/v1beta1/genesis.pulsar.go
…o longer returns {} when there aren't any SendEnabled entries and the default is false. SendEnabled is back to outputting a yaml format.
… set SendEnabled.
…or MsgSetSendEnabled.
Yup. Sorry, I had let it get a bit behind, but it's all good now. There's just the question of the My personal gut feeling is to have both; the overlapping responsibilities are small enough that it shouldn't be much of an extra burden. But I also don't mind getting rid of Just let me know which direction I should go on that. |
# Conflicts: # CHANGELOG.md
…mos/cosmos-sdk into dwedul/11859-send-enabled-w-gov-prop
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
… fields from MsgSetSendEnabled.
…nabled and default_send_enabled fields.
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
# Conflicts: # CHANGELOG.md # x/bank/spec/03_messages.md # x/bank/spec/README.md
…mos/cosmos-sdk into dwedul/11859-send-enabled-w-gov-prop # Conflicts: # CHANGELOG.md
…mos-sdk/simapp) in x/bank/app_test.go and update other go mod stuff associated with that.
Description
Closes: #11859
This PR is related to #11977. It creates and implements
MsgSetSendEnabled
, a message for use as a governance proposal to update the SendEnabled information.Note that this PR is currently set to merge into
dwedul/11859-send-disabled-change
instead ofmain
. This PR is dependent on functionality added by that branch. Once that PR has merged intomain
, I'll update this to also merge intomain
.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
addedN/A!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change