fix: cli `grants-by-grantee`, `grants-by-granter` cmds #11983

atheeshp · 2022-05-18T09:31:53Z

Description

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

anilcse

do we need a changelog?

anilcse · 2022-05-18T15:02:05Z

x/feegrant/client/cli/query.go

@@ -84,7 +84,7 @@ $ %s query feegrant grant [granter] [grantee]
 // GetCmdQueryFeeGrantsByGrantee returns cmd to query for all grants for a grantee.
 func GetCmdQueryFeeGrantsByGrantee() *cobra.Command {
 	cmd := &cobra.Command{
-		Use:   "grants [grantee]",
+		Use:   "grantee-grants [grantee]",


How about the following

Suggested change

Use: "grantee-grants [grantee]",

Use: "grants-by-grantee [grantee]",

…p/feegrant-cli

CHANGELOG.md

Co-authored-by: Julien Robert <julien@rbrt.fr>

codecov · 2022-05-19T13:45:59Z

Codecov Report

Merging #11983 (8c1f5e7) into main (78cafee) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #11983   +/-   ##
=======================================
  Coverage   66.02%   66.02%           
=======================================
  Files         677      677           
  Lines       71249    71249           
=======================================
+ Hits        47044    47045    +1     
+ Misses      21518    21517    -1     
  Partials     2687     2687

Impacted Files	Coverage Δ
crypto/keys/internal/ecdsa/privkey.go	`83.01% <0.00%> (+1.88%)`	⬆️

atheeshp · 2022-05-24T06:50:01Z

@AmauryM I think this PR need to be backported, since #10947 backported.

amaury1093 · 2022-05-24T10:55:12Z

Yes, you're right!

amaury1093 · 2022-05-24T10:55:23Z

@Mergifyio backport release/v0.45.x

mergify · 2022-05-24T10:56:08Z

backport release/v0.45.x

✅ Backports have been created

#12025 fix: cli grants-by-grantee, grants-by-granter cmds (backport #11983) has been created for branch release/v0.45.x

## Description ref: #11362 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit f470d40) # Conflicts: # CHANGELOG.md

…) (#12025) * fix: cli `grants-by-grantee`, `grants-by-granter` cmds (#11983) ## Description ref: #11362 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit f470d40) # Conflicts: # CHANGELOG.md * add alias * conflicts * fix * remove unneeded files * Update x/authz/client/cli/query.go Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: atheesh <atheesh@vitwit.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

…os#11983) (cosmos#12025) * fix: cli `grants-by-grantee`, `grants-by-granter` cmds (cosmos#11983) ## Description ref: cosmos#11362 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit f470d40) # Conflicts: # CHANGELOG.md * add alias * conflicts * fix * remove unneeded files * Update x/authz/client/cli/query.go Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com> Co-authored-by: atheesh <atheesh@vitwit.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

fix: cli grantee-grants, granter-grants cmds

577e978

github-actions bot added C:CLI C:x/feegrant labels May 18, 2022

atheeshp marked this pull request as ready for review May 18, 2022 09:49

atheeshp requested a review from a team as a code owner May 18, 2022 09:49

atheeshp requested review from amaury1093, blushi, likhita-809 and JeancarloBarrios May 18, 2022 11:33

julienrbrt approved these changes May 18, 2022

View reviewed changes

Merge branch 'main' into ap/feegrant-cli

caa5e2d

alexanderbez approved these changes May 18, 2022

View reviewed changes

Merge branch 'main' into ap/feegrant-cli

0cd55a9

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label May 18, 2022

Merge branch 'main' into ap/feegrant-cli

4715637

anilcse reviewed May 18, 2022

View reviewed changes

likhita-809 approved these changes May 18, 2022

View reviewed changes

amaury1093 removed the A:automerge Automatically merge PR once all prerequisites pass. label May 18, 2022

JeancarloBarrios and others added 3 commits May 18, 2022 12:49

Merge branch 'main' into ap/feegrant-cli

b35538e

Merge branch 'main' into ap/feegrant-cli

9136ab3

review changes

50fe15c

atheeshp changed the title ~~fix: cli grantee-grants, granter-grants cmds~~ fix: cli grants-by-grantee, grants-by-granter cmds May 19, 2022

atheeshp added 3 commits May 19, 2022 11:20

update changelog

99de8d7

Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/feegrant-cli

5b66b58

Merge branch 'ap/feegrant-cli' of github.com:cosmos/cosmos-sdk into a…

6f01ef4

…p/feegrant-cli

github-actions bot added the C:x/authz label May 19, 2022

atheeshp requested a review from anilcse May 19, 2022 05:52

anilcse approved these changes May 19, 2022

View reviewed changes

review changes

49cd696

atheeshp added the A:automerge Automatically merge PR once all prerequisites pass. label May 19, 2022

atheeshp removed the A:automerge Automatically merge PR once all prerequisites pass. label May 19, 2022

atheeshp commented May 19, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

d81cd2b

julienrbrt reviewed May 19, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

80cae80

Co-authored-by: Julien Robert <julien@rbrt.fr>

alexanderbez approved these changes May 19, 2022

View reviewed changes

Merge branch 'main' into ap/feegrant-cli

8c1f5e7

alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label May 19, 2022

mergify bot merged commit f470d40 into main May 19, 2022

mergify bot deleted the ap/feegrant-cli branch May 19, 2022 14:08

mergify bot mentioned this pull request May 24, 2022

fix: cli grants-by-grantee, grants-by-granter cmds (backport #11983) #12025

Merged

faddat mentioned this pull request Dec 11, 2023

chore: update to v0.45.16 cudoventures/cosmos-sdk#16

Draft

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: cli `grants-by-grantee`, `grants-by-granter` cmds #11983

fix: cli `grants-by-grantee`, `grants-by-granter` cmds #11983

atheeshp commented May 18, 2022 •

edited

Loading

anilcse left a comment

anilcse May 18, 2022

codecov bot commented May 19, 2022 •

edited

Loading

atheeshp commented May 24, 2022 •

edited

Loading

amaury1093 commented May 24, 2022

amaury1093 commented May 24, 2022

mergify bot commented May 24, 2022

	Use: "grantee-grants [grantee]",
	Use: "grants-by-grantee [grantee]",

fix: cli grants-by-grantee, grants-by-granter cmds #11983

fix: cli grants-by-grantee, grants-by-granter cmds #11983

Conversation

atheeshp commented May 18, 2022 • edited Loading

Description

Author Checklist

Reviewers Checklist

anilcse left a comment

Choose a reason for hiding this comment

anilcse May 18, 2022

Choose a reason for hiding this comment

codecov bot commented May 19, 2022 • edited Loading

Codecov Report

atheeshp commented May 24, 2022 • edited Loading

amaury1093 commented May 24, 2022

amaury1093 commented May 24, 2022

mergify bot commented May 24, 2022

✅ Backports have been created

fix: cli `grants-by-grantee`, `grants-by-granter` cmds #11983

fix: cli `grants-by-grantee`, `grants-by-granter` cmds #11983

atheeshp commented May 18, 2022 •

edited

Loading

codecov bot commented May 19, 2022 •

edited

Loading

atheeshp commented May 24, 2022 •

edited

Loading