refactor: Revert middlewares to antehandler (part 2/2: posthandler) #11985

amaury1093 · 2022-05-18T10:01:38Z

Description

We decided to remove middlewares, and revert to antehandlers (exactly like in v045) for this release. A better middleware solution will be implemented after v046.

ref: #11955

This PR is part 2 of 2:

part 1: Revert baseapp and middlewares to v0.45.4
part 2: Add posthandler, tips, priority

Depends on:

refactor: Revert middlewares to antehandlers (part 1/2: baseapp) #11979

Suggestion for reviewers:

Apart from correctness, I would also like someone to review exhaustiveness. I.e. all changes we made in v046 into the middleware folder are reflected in this PR, and that I didn't forget anything. I found the following ones:
- add a TxFeeChecker in DeductFee
- add a ExtensionChecker in ExtCheckerDecorator
- add a TipDecorator

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

x/auth/ante/tx_priority.go

baseapp/baseapp.go

alexanderbez

LGTM, but I don't see anywhere where we use ctx.Priority for CheckTx?

baseapp/baseapp.go

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

…sdk into am/revert-045-part2

amaury1093 · 2022-05-20T15:36:03Z

LGTM, but I don't see anywhere where we use ctx.Priority for CheckTx?

Oh yeah good catch, see 35866ff.

baseapp/baseapp.go

faddat · 2022-05-23T04:56:42Z

hey, if it is possible to "lgtm" that would be super because this PR is now blocking the refactors we need to do for craft. Thanks guys.

amaury1093 · 2022-05-23T09:46:42Z

simapp/app.go

+	// needs a coordinated upgrade.
+	//
+	// Uncomment to enable postHandlers:
+	// app.setPostHandler()


Any opinions if we should enable Tips by default on simapp (note: all chains that will copy-paste simapp might also enable them)? Is it a use case that's generic enough to be enabled by default on all cosmos chains?

I'd personally say no, and it's more a specific use-case, but would like to hear other opinions.

I would go with a yes, when we built craft, one of the discoveries that I think that we had is that an application template with all of the features turned on would be useful. Also, if we have this turned on in simapp, it gets tested

But if it’s there and come and to down at least it can be used. Just so that you know, craft began as an implementation of simapp.

basically I’d like to see a Nonsimapp app template in the sdk

I’ve been calling that tiny.

For various reasons Gaia is no longer a great template. Unfortunately the same can be said of starport.

Like yourself I think it’s not too much of a big deal in either direction if this is present directly in the simulation app or not but I would lean toward including it

amaury1093 · 2022-05-23T10:15:49Z

Going to put automerge on, to unblock downstream work.

Two decisions still need to be made:

Should posthandlers run in their own store branch? refactor: Revert middlewares to antehandler (part 2/2: posthandler) #11985 (comment). Currently: no, they run in the same one as runMsgs
Should tips be included in simapp by default? refactor: Revert middlewares to antehandler (part 2/2: posthandler) #11985 (comment). Currently: no, it's an opt-in feature.

I can create a follow-up PR if any decision changes on the two items above.

faddat · 2022-05-23T10:21:19Z

thanks @AmauryM :)

codecov · 2022-05-23T10:24:07Z

Codecov Report

Merging #11985 (92c1f0b) into main (b2af716) will decrease coverage by 0.02%.
The diff coverage is 78.14%.

@@            Coverage Diff             @@
##             main   #11985      +/-   ##
==========================================
- Coverage   66.02%   66.00%   -0.03%     
==========================================
  Files         672      671       -1     
  Lines       71232    70959     -273     
==========================================
- Hits        47032    46834     -198     
+ Misses      21523    21470      -53     
+ Partials     2677     2655      -22

Impacted Files	Coverage Δ
baseapp/options.go	`66.03% <0.00%> (-2.59%)`	⬇️
types/context.go	`88.40% <0.00%> (-2.64%)`	⬇️
x/auth/ante/sigverify.go	`67.41% <0.00%> (-0.66%)`	⬇️
x/auth/client/testutil/suite.go	`94.28% <68.75%> (+0.02%)`	⬆️
simapp/app.go	`81.05% <70.00%> (-0.95%)`	⬇️
baseapp/baseapp.go	`79.63% <77.77%> (-0.89%)`	⬇️
x/auth/ante/fee.go	`82.35% <87.50%> (ø)`
x/auth/ante/ext.go	`90.00% <89.47%> (-10.00%)`	⬇️
x/auth/ante/validator_tx_fee.go	`92.30% <92.30%> (ø)`
baseapp/abci.go	`64.05% <100.00%> (+0.06%)`	⬆️
... and 8 more

## Description ref: #11985 (comment) --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)

…osmos#11985) ## Description We decided to remove middlewares, and revert to antehandlers (exactly like in v045) for this release. A better middleware solution will be implemented after v046. ref: cosmos#11955 This PR is part 2 of 2: - part 1: Revert baseapp and middlewares to v0.45.4 - part 2: Add posthandler, tips, priority Depends on: - [x] cosmos#11979 --- Suggestion for reviewers: - Apart from correctness, I would also like someone to review **exhaustiveness**. I.e. all changes we made in v046 into the [middleware folder](https://github.com/cosmos/cosmos-sdk/tree/v0.46.0-beta2/x/auth/middleware) are reflected in this PR, and that I didn't forget anything. I found the following ones: - add a TxFeeChecker in DeductFee - add a ExtensionChecker in ExtCheckerDecorator - add a TipDecorator --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)

github-actions bot added C:CLI C:x/auth labels May 18, 2022

amaury1093 commented May 18, 2022

View reviewed changes

x/auth/ante/tx_priority.go Outdated Show resolved Hide resolved

amaury1093 commented May 18, 2022

View reviewed changes

baseapp/baseapp.go Show resolved Hide resolved

amaury1093 mentioned this pull request May 18, 2022

v0.46.0 Release #11096

Closed

56 tasks

faddat mentioned this pull request May 20, 2022

Craft Middleware refactor notional-labs/craft#114

Closed

Base automatically changed from am/revert-045-baseapp to main May 20, 2022 09:27

amaury1093 added 18 commits May 20, 2022 13:37

Make baseapp changes

1d8abfb

Revert middlewares

2b32ad5

Fix baseapp_test build

abd3ca6

Fix one test

43b5a4a

Fix simapp

fbc63dd

Fix more tests

0a07181

Fix another one?

f0a6d11

Fix ante test build

659c2bd

Fix amino tests

99c764b

Fix test

04c72a3

Fix block gas test

6fd336e

Small changes

09fd262

Add posthandler

6c78ed3

Add tips, priority

9e414ee

Add simapp posthandler

b07ba75

put priority under deduct

c622e9c

Fix sigverify

2724975

Make tips test pass

801a7d6

amaury1093 force-pushed the am/revert-045-part2 branch from 579f800 to 801a7d6 Compare May 20, 2022 12:00

github-actions bot added C:x/authz C:x/feegrant C:x/gov C:x/group labels May 20, 2022

amaury1093 added 2 commits May 20, 2022 16:56

Add comment on posthandler

d48d253

Run postHandler on simulate

46e2102

alexanderbez approved these changes May 20, 2022

View reviewed changes

baseapp/baseapp.go Show resolved Hide resolved

baseapp/baseapp.go Outdated Show resolved Hide resolved

amaury1093 and others added 3 commits May 20, 2022 17:16

Update baseapp/baseapp.go

aff7e01

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

Add priority back to checkTx

35866ff

Merge branch 'am/revert-045-part2' of ssh://github.com/cosmos/cosmos-…

1880bc3

…sdk into am/revert-045-part2

alexanderbez reviewed May 20, 2022

View reviewed changes

baseapp/baseapp.go Show resolved Hide resolved

julienrbrt approved these changes May 21, 2022

View reviewed changes

Merge branch 'main' into am/revert-045-part2

9a3cecb

faddat mentioned this pull request May 23, 2022

Cosmos SDK v46 CosmWasm/wasmd#863

Closed

amaury1093 added 2 commits May 23, 2022 11:38

Add comment for skipped test

1a39948

Add tips comments

be08978

amaury1093 commented May 23, 2022

View reviewed changes

Merge branch 'main' into am/revert-045-part2

92c1f0b

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label May 23, 2022

julienrbrt mentioned this pull request May 23, 2022

docs: revert middleware documentation and adds posthandler documentation #11988

Merged

21 tasks

mergify bot merged commit d416ee8 into main May 23, 2022

mergify bot deleted the am/revert-045-part2 branch May 23, 2022 10:32

amaury1093 mentioned this pull request May 23, 2022

refactor: Add Tips decorator in simapp #12016

Merged

19 tasks

nghuyenthevinh2000 mentioned this pull request Aug 19, 2022

chore: sdk v46 evmos/evmos#786

Merged

12 tasks

Kbhat1 mentioned this pull request Sep 21, 2022

Add priority to check tx based on gas fees sei-protocol/sei-cosmos#23

Merged

LampardNguyen234 mentioned this pull request Aug 15, 2023

deps: bump cosmos-sdk v0.46 and evmos v12 AstraProtocol/astra#209

Merged

GNaD13 mentioned this pull request Aug 23, 2023

Change Mempool Ante to TxFeeChecker osmosis-labs/fee-abstraction#74

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Revert middlewares to antehandler (part 2/2: posthandler) #11985

refactor: Revert middlewares to antehandler (part 2/2: posthandler) #11985

amaury1093 commented May 18, 2022 •

edited

Loading

alexanderbez left a comment

amaury1093 commented May 20, 2022

faddat commented May 23, 2022

amaury1093 May 23, 2022

faddat May 23, 2022

faddat May 23, 2022

faddat May 23, 2022

faddat May 23, 2022

amaury1093 commented May 23, 2022

faddat commented May 23, 2022

codecov bot commented May 23, 2022

refactor: Revert middlewares to antehandler (part 2/2: posthandler) #11985

refactor: Revert middlewares to antehandler (part 2/2: posthandler) #11985

Conversation

amaury1093 commented May 18, 2022 • edited Loading

Description

Author Checklist

Reviewers Checklist

alexanderbez left a comment

Choose a reason for hiding this comment

amaury1093 commented May 20, 2022

faddat commented May 23, 2022

amaury1093 May 23, 2022

Choose a reason for hiding this comment

faddat May 23, 2022

Choose a reason for hiding this comment

faddat May 23, 2022

Choose a reason for hiding this comment

faddat May 23, 2022

Choose a reason for hiding this comment

faddat May 23, 2022

Choose a reason for hiding this comment

amaury1093 commented May 23, 2022

faddat commented May 23, 2022

codecov bot commented May 23, 2022

Codecov Report

amaury1093 commented May 18, 2022 •

edited

Loading