Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: store audit changes #11989

Merged
merged 3 commits into from
May 18, 2022
Merged

chore: store audit changes #11989

merged 3 commits into from
May 18, 2022

Conversation

likhita-809
Copy link
Contributor

Description

ref: #11362


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 marked this pull request as ready for review May 18, 2022 14:41
@likhita-809 likhita-809 requested a review from a team as a code owner May 18, 2022 14:41
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #11989 (78cd423) into main (b647802) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11989      +/-   ##
==========================================
- Coverage   66.02%   66.02%   -0.01%     
==========================================
  Files         677      680       +3     
  Lines       71341    71548     +207     
==========================================
+ Hits        47103    47237     +134     
- Misses      21551    21607      +56     
- Partials     2687     2704      +17     
Impacted Files Coverage Δ
store/tracekv/store.go 92.00% <ø> (ø)
store/types/store.go 70.73% <ø> (ø)
store/types/utils.go 100.00% <ø> (ø)
store/types/validity.go 100.00% <ø> (ø)
x/distribution/simulation/operations.go 80.54% <0.00%> (-9.73%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️
store/tools/ics23/smt/create.go 65.11% <0.00%> (ø)
store/tools/ics23/iavl/create.go 63.26% <0.00%> (ø)
store/tools/ics23/iavl/convert.go 91.66% <0.00%> (ø)

store/tools/ics23/smt/helpers/random.go Outdated Show resolved Hide resolved
@@ -13,7 +13,7 @@ current value). This returns an error if the key does not exist in the tree.

`func CreateNonMembershipProof(tree *iavl.MutableTree, key []byte) (*proofs.CommitmentProof, error)`
produces a CommitmentProof that the given key doesn't exist in the iavl tree.
This returns an error if the key does not exist in the tree.
This returns an error if the key exists in the tree.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label May 18, 2022
@mergify mergify bot merged commit 0b810ba into main May 18, 2022
@mergify mergify bot deleted the likhita/store-audit branch May 18, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants