Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Db linting #12141

Merged
merged 52 commits into from
Jun 8, 2022
Merged

chore: Db linting #12141

merged 52 commits into from
Jun 8, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jun 3, 2022

Description

This PR makes breaking changes. Specifically, it renames the Reader, Writer, ReadWriter, and Connection to more human friendly names, and complies with the linter while doing so.

Basically, this PR advances the goals of #12133 by dramatically improving the naming compliance of the cosmos-sdk.

I completed this PR by fixing most linting problems in the cosmos-sdk.

Where possible, I favored solving the underlying issue over using //nolint:*

In many cases, this meant changing the names of things more than I'd normally be comfortable with, to try and move towards standardization.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat
Copy link
Contributor Author

faddat commented Jun 3, 2022

Apparently that was one of the odd intermittent test failures, and this one is ready to go!

@faddat
Copy link
Contributor Author

faddat commented Jun 8, 2022

the diff is complete, so that the secp256k1 folder will show only nolint lines as the difference from main

@tac0turtle tac0turtle merged commit b0e82f9 into cosmos:main Jun 8, 2022
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* mainly sdk.int to cosmossdk.io/math

* staking keys

* fumpt

* var-naming linter errors and a fumpt

* Update CHANGELOG.md

* Update .golangci.yml

* Update CHANGELOG.md

* Update test_helpers.go

* Update test_helpers.go

* fumpt and lint

* this lints the db module, and makes it easier to use.  It adds breaking name changes

* DBConnection -> Connection

* previous commit contained a merge error

* Update test_helpers.go

* Update test_helpers.go

* db renamings

* merge master

* changelog

* DBWriter -> Writer

* consistent multistore reciever

* standard recievers for multistore v2alpha1

* general cleanup of linting issues

* more linter fixes

* remove prealloc linter

* nolint the secp256k1 import

* nolint the secp256k1 package

* completenolint resulting in a diff that has only nolints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants