-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(orm)!: timestamp encoding doesn't handle nil values properly #12273
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #12273 +/- ##
==========================================
+ Coverage 56.25% 66.11% +9.85%
==========================================
Files 667 675 +8
Lines 56576 71275 +14699
==========================================
+ Hits 31829 47122 +15293
+ Misses 22165 21508 -657
- Partials 2582 2645 +63
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
closing as orm is not an epic within the current workscope of the team. We can reopen when we complete app wiring |
…-orm-timestamp-encoding
Reopening this as I'd like to quickly address the outstanding issuing blocking ORM from being considered v1.0 and feature complete. |
…ing' into aaronc/11980-orm-timestamp-encoding
- [14822](https://github.com/cosmos/cosmos-sdk/pull/14822) Migrate to cosmossdk.io/core genesis API | ||
|
||
### State-machine Breaking Changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have docs, upgrading tooling on that. Otherwise, it feels a bit like "good luck".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm planning to push another PR for ORM migrations that will automate this
That queue thing does not work. |
What's the queue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
…mos#12273) Co-authored-by: Julien Robert <julien@rbrt.fr>
Description
Ref #11980
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change