Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orm)!: timestamp encoding doesn't handle nil values properly #12273

Merged
merged 15 commits into from
Feb 9, 2023

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Jun 15, 2022

Description

Ref #11980


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #12273 (40167f0) into main (2739f83) will increase coverage by 9.85%.
The diff coverage is n/a.

❗ Current head 40167f0 differs from pull request most recent head b04a9ca. Consider uploading reports for the commit b04a9ca to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12273      +/-   ##
==========================================
+ Coverage   56.25%   66.11%   +9.85%     
==========================================
  Files         667      675       +8     
  Lines       56576    71275   +14699     
==========================================
+ Hits        31829    47122   +15293     
+ Misses      22165    21508     -657     
- Partials     2582     2645      +63     
Impacted Files Coverage Δ
x/auth/client/cli/validate_sigs.go 0.00% <0.00%> (-80.00%) ⬇️
x/genutil/client/cli/validate_genesis.go 0.00% <0.00%> (-78.05%) ⬇️
x/auth/client/cli/broadcast.go 0.00% <0.00%> (-75.00%) ⬇️
x/distribution/client/cli/query.go 0.00% <0.00%> (-73.95%) ⬇️
x/slashing/keeper/msg_server.go 9.09% <0.00%> (-73.52%) ⬇️
x/distribution/client/cli/tx.go 4.13% <0.00%> (-71.15%) ⬇️
x/genutil/client/cli/migrate.go 0.00% <0.00%> (-65.34%) ⬇️
x/staking/client/cli/query.go 0.00% <0.00%> (-63.07%) ⬇️
x/gov/client/cli/tx.go 14.00% <0.00%> (-56.52%) ⬇️
x/bank/keeper/msg_server.go 3.03% <0.00%> (-51.77%) ⬇️
... and 561 more

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 3, 2022
@tac0turtle
Copy link
Member

closing as orm is not an epic within the current workscope of the team. We can reopen when we complete app wiring

@tac0turtle tac0turtle closed this Aug 3, 2022
@aaronc aaronc reopened this Feb 7, 2023
@aaronc aaronc removed the stale label Feb 7, 2023
@aaronc
Copy link
Member Author

aaronc commented Feb 7, 2023

Reopening this as I'd like to quickly address the outstanding issuing blocking ORM from being considered v1.0 and feature complete.

@aaronc aaronc marked this pull request as ready for review February 7, 2023 23:08
@aaronc aaronc requested a review from a team as a code owner February 7, 2023 23:08
@aaronc aaronc requested review from JeancarloBarrios, kocubinski and amaury1093 and removed request for alexanderbez and facundomedica February 7, 2023 23:08
@aaronc aaronc changed the title fix(orm)!: timestamp encoding doesn't handle nil values fix(orm)!: timestamp encoding doesn't handle nil values properly Feb 8, 2023
- [14822](https://github.com/cosmos/cosmos-sdk/pull/14822) Migrate to cosmossdk.io/core genesis API

### State-machine Breaking Changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have docs, upgrading tooling on that. Otherwise, it feels a bit like "good luck".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning to push another PR for ORM migrations that will automate this

@julienrbrt julienrbrt added this pull request to the merge queue Feb 9, 2023
@julienrbrt julienrbrt removed this pull request from the merge queue due to a manual request Feb 9, 2023
@julienrbrt julienrbrt added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 9, 2023
@julienrbrt
Copy link
Member

That queue thing does not work.

@julienrbrt julienrbrt enabled auto-merge (squash) February 9, 2023 16:53
@aaronc
Copy link
Member Author

aaronc commented Feb 9, 2023

That queue thing does not work.

What's the queue?

Copy link
Contributor

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aaronc aaronc merged commit dc20731 into main Feb 9, 2023
@aaronc aaronc deleted the aaronc/11980-orm-timestamp-encoding branch February 9, 2023 17:25
tsenart pushed a commit to meka-dev/cosmos-sdk that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:orm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants