feat(x/staking): add app wiring support for StakingHooks #12291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This was referenced Jun 17, 2022
julienrbrt
approved these changes
Jun 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #12291 +/- ##
==========================================
+ Coverage 66.13% 66.15% +0.02%
==========================================
Files 675 676 +1
Lines 71287 71315 +28
==========================================
+ Hits 47144 47177 +33
+ Misses 21503 21493 -10
- Partials 2640 2645 +5
|
julienrbrt
reviewed
Jun 22, 2022
| "testing" | ||
|
|
||
| "github.com/regen-network/gocuke" | ||
| "gotest.tools/v3/assert" |
There was a problem hiding this comment.
nit: I've noticed some tests use this package instead of testify. I think it makes more sense to generalize everything to use testify.
There was a problem hiding this comment.
I actually think we should use gotest.tools instead of testify wherever possible. There are longstanding issues with testify in particular stretchr/testify#535 which is a deal breaker for comparing protobuf values and stretchr/testify#187 (testify suites should be considered an anti-pattern because of this). IMHO testify is a bit stuck in the past and has maybe gotten a bit too big to maintain. gotest.tools is minimal and correct (in particular because of https://pkg.go.dev/gotest.tools/v3/assert#DeepEqual) and also comes with useful support for golden files
There was a problem hiding this comment.
can we open an issue for this? the migration can be a good first issue
There was a problem hiding this comment.
I have created #12332, feel free to edit it.
julienrbrt
reviewed
Jun 22, 2022
Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt
added
the
A:automerge
4 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
## Description Ref cosmos#12036 Depends on app wiring for x/distribution getting merged first (cosmos#12292) --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref #12036
Depends on app wiring for x/distribution getting merged first (#12292)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change