Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed deprecated sdk.DBBackend variable #12355

Merged
merged 14 commits into from
Jul 8, 2022

Conversation

deepto98
Copy link
Contributor

@deepto98 deepto98 commented Jun 25, 2022

Description

Closes: #11410
#11241


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@deepto98 deepto98 requested a review from a team as a code owner June 25, 2022 07:56
@deepto98 deepto98 mentioned this pull request Jun 25, 2022
4 tasks
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a changelog for this.

@tac0turtle
Copy link
Member

LGTM, looks to be a few more stragglers of DBBackened still existing

@deepto98
Copy link
Contributor Author

Let's add a changelog for this.

Okay, will do.

@alexanderbez
Copy link
Contributor

Let's add a changelog for this.

Okay, will do.

TYSM. Also, great work 👍

@deepto98
Copy link
Contributor Author

deepto98 commented Jul 3, 2022

@alexanderbez I've removed the other occurences I could find of types.DBBackend and also added a changelog.

CHANGELOG.md Show resolved Hide resolved
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
CHANGELOG.md Show resolved Hide resolved
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #12355 (9dff262) into main (69d8fa2) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12355      +/-   ##
==========================================
- Coverage   65.57%   65.55%   -0.03%     
==========================================
  Files         685      685              
  Lines       71638    71634       -4     
==========================================
- Hits        46976    46957      -19     
- Misses      22013    22030      +17     
+ Partials     2649     2647       -2     
Impacted Files Coverage Δ
types/utils.go 79.10% <ø> (+3.04%) ⬆️
x/distribution/simulation/operations.go 80.85% <0.00%> (-9.58%) ⬇️

@mergify mergify bot merged commit fd7cdd6 into cosmos:main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sdk.DBBackend
5 participants