refactor: Use mocks for x/nft testing

[facundomedica]

Description

Ref: #12398

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[alexanderbez]

@facundomedica can you reference the issue/epic in the PR body pls? :)

[alexanderbez]

Hell yeah! Nice work @facundomedica

[alexanderbez]

sorry one more thing. Why not have this take a *testing.T and that way we can do an assertion and avoid the silly panic?

[julienrbrt]

lgtm!

[tac0turtle]

once cli tests are migrated to mocks, we can remove these right?.

[facundomedica]

It's not really clear to me how to migrate the cli tests to mocks, can you share some pointers? To me it seems that it will be a big-ish rewrite, will merge this and come to it when I have more ideas on how to make it happen

[alexanderbez]

So we have to re-write CLI integration tests such that we can finally remove the dependency on in-process Tendermint. We can achieve this one of two ways:

1. Mock Tendermint, i.e. create a super dumb and simple ABCI wrapper.
2. Mock the commands themselves, via outputs/inputs.

I'd rather go with option (1) as that'll be much less of a massive re-write. In fact, CLI tests wont have to change at all!

We spoke about this in Lisbon. When Marko is referring to mocks, he's referring to mocking Tendermint.

[facundomedica]

Gotcha, I'll start looking into that

[alexanderbez]

Please merge this when ready @facundomedica