Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate x/params usage in x/distr #12434

Merged
merged 31 commits into from
Jul 8, 2022
Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
c44408c
WIP: distribution params
atheeshp Jul 1, 2022
996e987
git changes
atheeshp Jul 4, 2022
c267df7
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/distr-params
atheeshp Jul 4, 2022
f2b8e7f
legacy params
atheeshp Jul 4, 2022
bb67de0
add migrations
atheeshp Jul 4, 2022
64d0385
add keeper tests
atheeshp Jul 4, 2022
03046cc
add msg server tests
atheeshp Jul 4, 2022
772538a
add migrate tests
atheeshp Jul 4, 2022
39b630d
add change log
atheeshp Jul 4, 2022
bee77f6
review changes
atheeshp Jul 4, 2022
f85bf67
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/distr-params
atheeshp Jul 4, 2022
e6bb54f
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/distr-params
atheeshp Jul 5, 2022
3b79ecb
review changes
atheeshp Jul 6, 2022
89ada2a
update codec
atheeshp Jul 6, 2022
aea9c8c
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/distr-params
atheeshp Jul 6, 2022
f2bead1
review
atheeshp Jul 6, 2022
17dc70c
fix error
atheeshp Jul 6, 2022
6da117e
fix error
atheeshp Jul 6, 2022
366d17c
fix tests
atheeshp Jul 6, 2022
be784e2
review
atheeshp Jul 6, 2022
5545572
review changes
atheeshp Jul 6, 2022
8822ef2
review changes
atheeshp Jul 6, 2022
d607546
Merge branch 'main' into ap/distr-params
alexanderbez Jul 6, 2022
b6f8934
update changelog
atheeshp Jul 7, 2022
22eb721
review
atheeshp Jul 7, 2022
b2922c1
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/distr-params
atheeshp Jul 7, 2022
4c125b3
update spec
atheeshp Jul 7, 2022
2b2a21c
Merge branch 'ap/distr-params' of github.com:cosmos/cosmos-sdk into a…
atheeshp Jul 7, 2022
29028f3
update evetns
atheeshp Jul 8, 2022
7aefd9c
review changes
atheeshp Jul 8, 2022
c96129a
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/distr-params
atheeshp Jul 8, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

* (x/slashing) [#12399](https://github.com/cosmos/cosmos-sdk/pull/12399) Migrate `x/slashing` to self-managed parameters and deprecate its usage of `x/params`.
* (x/mint) [#12363](https://github.com/cosmos/cosmos-sdk/pull/12363) Migrate `x/mint` to self-managed parameters and deprecate it's usage of `x/params`.
* (x/distribution) [#12434](https://github.com/cosmos/cosmos-sdk/pull/12434) Migrate `x/distribution` to self-managed parameters and deprecate it's usage of `x/params`.

### API Breaking Changes

Expand All @@ -65,6 +66,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (testutil) [#12233](https://github.com/cosmos/cosmos-sdk/pull/12233) Move `simapp.TestAddr` to `simtestutil.TestAddr` (`testutil/sims`)
* (x/staking) [#12102](https://github.com/cosmos/cosmos-sdk/pull/12102) Staking keeper now is passed by reference instead of copy. Keeper's SetHooks no longer returns keeper. It updates the keeper in place instead.
* (linting) [#12141](https://github.com/cosmos/cosmos-sdk/pull/12141) Fix usability related linting for database. This means removing the infix Prefix from `prefix.NewPrefixWriter` and such so that it is `prefix.NewWriter` and making `db.DBConnection` and such into `db.Connection`
* (x/distribution) [#12434](https://github.com/cosmos/cosmos-sdk/pull/12434) `x/distribution` module `SetParams` keeper method definition is now updated to return `error`.


### Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion api/cosmos/app/v1alpha1/config.pulsar.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/cosmos/distribution/v1beta1/genesis.pulsar.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading