-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (x/bank) add SpendableCoin
method to BaseViewKeeper
#12593
feat: (x/bank) add SpendableCoin
method to BaseViewKeeper
#12593
Conversation
@hallazzang I'm not really sure we need a gRPC query for this. We already have one for spendable coins. Maybe we can just add a query param to that one to filter by a single denom. No need for a whole new query. |
@alexanderbez Oh, I see. I agree with you. I'll finish the other tasks then. |
Can we add a changelog? :) |
@julienrbrt Sure. I've updated the CHANGELOG file and also merged main into this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Codecov Report
@@ Coverage Diff @@
## main #12593 +/- ##
=======================================
Coverage 65.19% 65.19%
=======================================
Files 693 693
Lines 71802 71806 +4
=======================================
+ Hits 46809 46812 +3
- Misses 22359 22360 +1
Partials 2634 2634
|
Description
Closes: #12570
SpendableCoin
methodAdd gRPC query(Not needed)This PR adds
SpendableCoin
method to the bank module'sBaseViewKeeper
.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change