Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs on param module deprecation #12611

Merged
merged 8 commits into from
Aug 8, 2022
Merged

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Jul 18, 2022

Description

Closes: #12496

Update docs on param module deprecation.

Open Todos:

  • consensus params solution
  • Deprecation of the transient store? We will hold off on deprecating the transient store for another PR

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@tac0turtle tac0turtle marked this pull request as ready for review August 7, 2022 19:44
@tac0turtle tac0turtle requested a review from a team as a code owner August 7, 2022 19:44
x/params/spec/README.md Outdated Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
tac0turtle and others added 4 commits August 8, 2022 15:16
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@tac0turtle tac0turtle merged commit 048c709 into main Aug 8, 2022
@tac0turtle tac0turtle deleted the marko/12496-param-docs branch August 8, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Param deprecation documentation
4 participants