Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove broadcast mode block #12659

Merged
merged 25 commits into from
Sep 23, 2022

Conversation

julienrbrt
Copy link
Member

Description

Closes: #12167


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt linked an issue Jul 20, 2022 that may be closed by this pull request
@julienrbrt julienrbrt changed the title feat: deprecate and phase out broadcast mode block feat: remove broadcast mode block Jul 20, 2022
@tac0turtle tac0turtle marked this pull request as ready for review August 1, 2022 07:23
@tac0turtle tac0turtle requested a review from a team as a code owner August 1, 2022 07:23
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #12659 (e64760f) into main (4fe7797) will decrease coverage by 1.24%.
The diff coverage is 28.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12659      +/-   ##
==========================================
- Coverage   55.87%   54.63%   -1.25%     
==========================================
  Files         646      671      +25     
  Lines       54895    57693    +2798     
==========================================
+ Hits        30675    31518     +843     
- Misses      21762    23635    +1873     
- Partials     2458     2540      +82     
Impacted Files Coverage Δ
baseapp/grpcrouter.go 90.00% <ø> (ø)
baseapp/grpcrouter_helpers.go 25.00% <ø> (ø)
baseapp/grpcserver.go 1.72% <ø> (ø)
baseapp/msg_service_router.go 85.29% <ø> (+4.41%) ⬆️
baseapp/options.go 67.92% <0.00%> (-0.60%) ⬇️
client/broadcast.go 54.54% <ø> (+2.99%) ⬆️
client/cmd.go 57.73% <ø> (ø)
client/config/toml.go 55.55% <ø> (ø)
client/context.go 54.49% <ø> (-1.79%) ⬇️
client/flags/flags.go 19.35% <ø> (-0.32%) ⬇️
... and 231 more

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love PRs that remove code!

proto/cosmos/tx/v1beta1/service.proto Outdated Show resolved Hide resolved
x/authz/client/testutil/query.go Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

proto/cosmos/tx/v1beta1/service.proto Show resolved Hide resolved
@amaury1093 amaury1093 self-assigned this Aug 3, 2022
@julienrbrt julienrbrt marked this pull request as draft August 7, 2022 09:01
@julienrbrt
Copy link
Member Author

back to this, sorry for the delay

@julienrbrt julienrbrt force-pushed the julien/deprecate-broadcast-mode-block branch from 6a30d62 to 9c09965 Compare August 23, 2022 10:08
@github-actions github-actions bot added C:Cosmovisor Issues and PR related to Cosmovisor C:x/bank labels Aug 23, 2022
@julienrbrt julienrbrt force-pushed the julien/deprecate-broadcast-mode-block branch from c9586a0 to f70b07c Compare August 25, 2022 19:21
@julienrbrt julienrbrt force-pushed the julien/deprecate-broadcast-mode-block branch from ad83c0f to 76ee504 Compare September 2, 2022 13:20
@julienrbrt julienrbrt force-pushed the julien/deprecate-broadcast-mode-block branch from 266ed38 to 31c9df9 Compare September 22, 2022 11:54
@julienrbrt julienrbrt enabled auto-merge (squash) September 23, 2022 14:29
@julienrbrt julienrbrt changed the title feat: remove broadcast mode block refactor!: remove broadcast mode block Sep 23, 2022
@julienrbrt julienrbrt disabled auto-merge September 23, 2022 14:30
@julienrbrt julienrbrt enabled auto-merge (squash) September 23, 2022 14:30
@julienrbrt julienrbrt merged commit df40c0a into main Sep 23, 2022
@julienrbrt julienrbrt deleted the julien/deprecate-broadcast-mode-block branch September 23, 2022 15:16
@alexanderbez
Copy link
Contributor

Great job on pushing this over the finish line @julienrbrt

bravo 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Deprecate and phase out broadcast mode block.
4 participants