refactor: add mock unit tests for bank module #12721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cool-develope
force-pushed
the
john/mock-test-bank
branch
from
6754426 to
f08617e
Compare
github-actions
bot
added
C:CLI
C:Rosetta
cool-develope
force-pushed
the
john/mock-test-bank
branch
from
f08617e to
9952b31
Compare
github-actions
bot
removed
C:x/genutil
cool-develope
force-pushed
the
john/mock-test-bank
branch
from
9952b31 to
07d6055
Compare
cool-develope
changed the title
kocubinski
reviewed
Jul 26, 2022
x/bank/keeper/keeper_test.go
Outdated
| err = keeper.MintCoins(ctx, authtypes.Minter, sdk.Coins{sdk.Coin{Denom: "denom", Amount: sdk.NewInt(-10)}}) | ||
| suite.Require().Error(err, "insufficient coins") | ||
| suite.mockMintCoins(burnerAcc) | ||
| require.Panics(func() { keeper.MintCoins(ctx, authtypes.Burner, initCoins) }, "invalid permission") // nolint:errcheck |
There was a problem hiding this comment.
Even though we're expecting a panic, probably best to handle the error like you have above:
Suggested change
| require.Panics(func() { keeper.MintCoins(ctx, authtypes.Burner, initCoins) }, "invalid permission") // nolint:errcheck | |
| require.Panics(func() { _ = keeper.MintCoins(ctx, authtypes.Burner, initCoins) }, "invalid permission") // nolint:errcheck |
kocubinski
reviewed
Jul 26, 2022
x/bank/keeper/keeper_test.go
Outdated
| authKeeper.SetModuleAccount(ctx, multiPermAcc) | ||
| authKeeper.SetModuleAccount(ctx, randomPermAcc) | ||
| require := suite.Require() | ||
| authKeeper, keeper := suite.authKeeper, suite.keeper |
There was a problem hiding this comment.
nitpick: the var name keeper shadows the imported package name
kocubinski
reviewed
Jul 26, 2022
| @@ -8,6 +8,7 @@ import ( | |||
| "github.com/cosmos/cosmos-sdk/telemetry" | |||
| sdk "github.com/cosmos/cosmos-sdk/types" | |||
| "github.com/cosmos/cosmos-sdk/types/errors" | |||
| sdkerrors "github.com/cosmos/cosmos-sdk/types/errors" | |||
There was a problem hiding this comment.
The same package seems to be import twice with a different alias the second time.
kocubinski
approved these changes
Jul 26, 2022
facundomedica
approved these changes
Jul 26, 2022
cool-develope
commented
Jul 27, 2022
| @@ -59,3 +61,113 @@ func (suite *IntegrationTestSuite) TestMsgUpdateParams() { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
@facundomedica I added new test-cases for MsgSend and MsgMultiSend
27 tasks
facundomedica
approved these changes
Jul 27, 2022
facundomedica
added
the
A:automerge
julienrbrt
requested changes
Jul 27, 2022
x/bank/keeper/keeper_test.go
Outdated
| key := sdk.NewKVStoreKey(banktypes.StoreKey) | ||
| testCtx := testutil.DefaultContextWithDB(suite.T(), key, sdk.NewTransientStoreKey("transient_test")) | ||
| ctx := testCtx.Ctx.WithBlockHeader(tmproto.Header{Time: tmtime.Now()}) | ||
| encCfg := moduletestutil.MakeTestEncodingConfig(module.AppModuleBasic{}) |
There was a problem hiding this comment.
Suggested change
| encCfg := moduletestutil.MakeTestEncodingConfig(module.AppModuleBasic{}) | |
| encCfg := moduletestutil.MakeTestEncodingConfig() |
x/bank/keeper/keeper_test.go
Outdated
| banktypes "github.com/cosmos/cosmos-sdk/x/bank/types" | ||
| govtypes "github.com/cosmos/cosmos-sdk/x/gov/types" | ||
| minttypes "github.com/cosmos/cosmos-sdk/x/mint/types" | ||
| "github.com/cosmos/cosmos-sdk/x/nft/module" |
There was a problem hiding this comment.
Suggested change
| "github.com/cosmos/cosmos-sdk/x/nft/module" |
We don't need the NFT module.
julienrbrt
approved these changes
Jul 27, 2022
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #12503
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change