Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove comosvisor from go.work #12743

Merged
merged 5 commits into from
Jul 27, 2022
Merged

Conversation

julienrbrt
Copy link
Member

Description

ref: #12675 (comment)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner July 27, 2022 10:04
@julienrbrt julienrbrt changed the title build: remove comosvisor from go work build: remove comosvisor from go.work Jul 27, 2022
@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Jul 27, 2022
@julienrbrt julienrbrt marked this pull request as draft July 27, 2022 10:20
@julienrbrt julienrbrt marked this pull request as ready for review July 27, 2022 10:29
@@ -101,7 +107,7 @@ require (
github.com/tendermint/btcd v0.1.1 // indirect
github.com/tendermint/crypto v0.0.0-20191022145703-50d29ede1e15 // indirect
github.com/tendermint/go-amino v0.16.0 // indirect
github.com/tendermint/tendermint v0.35.9 // indirect
github.com/tendermint/tendermint v0.34.20 // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nevermind I am wrong. We haven't reverted the main branch, this is actually correct.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, but this still leads to dependencies errors: try a go mod tidy in ./cosmovisor on main

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh because it imports the sdk. uhhhhhhh that should be removed imo. Then this is avoided. Il create and issue for now

Copy link
Member Author

@julienrbrt julienrbrt Jul 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the issue? I don't think importing the sdk is an issue is it? That way we are sure to have the right plan type for instance. Plus, the Cosmos SDK does not import Cosmovisor, so I don't think having it present in the go.work made sense anyway.

@julienrbrt julienrbrt merged commit 09553f1 into main Jul 27, 2022
@julienrbrt julienrbrt deleted the julien/go-work-cosmovisor branch July 27, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Cosmovisor Issues and PR related to Cosmovisor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants