-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove comosvisor from go.work
#12743
Conversation
go work
go.work
@@ -101,7 +107,7 @@ require ( | |||
github.com/tendermint/btcd v0.1.1 // indirect | |||
github.com/tendermint/crypto v0.0.0-20191022145703-50d29ede1e15 // indirect | |||
github.com/tendermint/go-amino v0.16.0 // indirect | |||
github.com/tendermint/tendermint v0.35.9 // indirect | |||
github.com/tendermint/tendermint v0.34.20 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah nevermind I am wrong. We haven't reverted the main branch, this is actually correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, but this still leads to dependencies errors: try a go mod tidy in ./cosmovisor on main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh because it imports the sdk. uhhhhhhh that should be removed imo. Then this is avoided. Il create and issue for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the issue? I don't think importing the sdk is an issue is it? That way we are sure to have the right plan type for instance. Plus, the Cosmos SDK does not import Cosmovisor, so I don't think having it present in the go.work made sense anyway.
Description
ref: #12675 (comment)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change