Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: x/gov migrations #13045

Merged
merged 7 commits into from
Aug 29, 2022
Merged

fix: x/gov migrations #13045

merged 7 commits into from
Aug 29, 2022

Conversation

atheeshp
Copy link
Contributor

Description

Closes: #13044

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp changed the title fix: x/gov migration tests fix: x/gov migration Aug 25, 2022
@atheeshp atheeshp changed the title fix: x/gov migration fix: x/gov migrations Aug 25, 2022
@github-actions github-actions bot added C:x/genutil genutil module issues C:x/gov labels Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022 •
edited
Loading

Codecov Report

Merging #13045 (f911f60) into main (bc274d8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13045      +/-   ##
==========================================
+ Coverage   54.06%   54.07%   +0.01%     
==========================================
  Files         644      645       +1     
  Lines       54956    54969      +13     
==========================================
+ Hits        29710    29724      +14     
+ Misses      22887    22886       -1     
  Partials     2359     2359
Impacted Files Coverage Δ
x/gov/migrations/v3/json.go 70.00% <100.00%> (-6.00%) ⬇️
x/gov/migrations/v4/json.go 100.00% <100.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️

atheeshp
atheeshp commented Aug 29, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@atheeshp atheeshp marked this pull request as ready for review August 29, 2022 04:43
@atheeshp atheeshp requested a review from a team as a code owner August 29, 2022 04:43
amaury1093
amaury1093 approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

likhita-809
likhita-809 approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x/genutil/migrations/v047/migrate.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 29, 2022
@atheeshp atheeshp removed the A:automerge Automatically merge PR once all prerequisites pass. label Aug 29, 2022
@atheeshp atheeshp added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 29, 2022
@julienrbrt julienrbrt merged commit 08ed437 into main Aug 29, 2022
@julienrbrt julienrbrt deleted the ap/gov-json-migrations branch August 29, 2022 13:15
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
@atheeshp @Wryhder
fix: x/gov migrations (cosmos#13045)
87fc042 
* fix migration tests

* add change log

* Update CHANGELOG.md

* review changes

* review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/genutil genutil module issues C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect migrations for x/gov params
5 participants
@atheeshp @amaury1093 @julienrbrt @likhita-809 @tac0turtle