Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: proto image migrate to ghcr #13168

Merged
merged 9 commits into from
Sep 7, 2022
Merged

chore: proto image migrate to ghcr #13168

merged 9 commits into from
Sep 7, 2022

Conversation

tac0turtle
Copy link
Member

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review September 7, 2022 05:59
@tac0turtle tac0turtle requested a review from a team as a code owner September 7, 2022 05:59
@tac0turtle tac0turtle changed the title image chore: proto image migrate to ghcr Sep 7, 2022
protoVer=v0.8
protoImageName=tendermintdev/sdk-proto-gen:$(protoVer)
protoVer=0.8
protoImageName=ghcr.io/cosmos/proto-builder:$(protoVer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool! We may need to inform people using this that the image on the hub.docker.com won't be updated anymore. Does it need a changelog, then? Or an upgrading.md entry?

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #13168 (46d2278) into main (4a07259) will increase coverage by 0.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13168      +/-   ##
==========================================
+ Coverage   54.05%   54.76%   +0.71%     
==========================================
  Files         645      685      +40     
  Lines       55271    58330    +3059     
==========================================
+ Hits        29874    31944    +2070     
- Misses      23014    23725     +711     
- Partials     2383     2661     +278     
Impacted Files Coverage Δ
x/staking/simulation/operations.go 74.54% <0.00%> (-1.38%) ⬇️
x/group/keeper/keeper.go 56.25% <0.00%> (-0.40%) ⬇️
orm/model/ormtable/backend.go 66.07% <0.00%> (ø)
orm/model/ormtable/index_impl.go 49.25% <0.00%> (ø)
orm/model/ormtable/unique.go 44.09% <0.00%> (ø)
orm/encoding/ormfield/timestamp.go 76.31% <0.00%> (ø)
orm/encoding/ormkv/entry.go 77.27% <0.00%> (ø)
orm/encoding/ormfield/bool.go 81.48% <0.00%> (ø)
orm/internal/stablejson/encode.go 67.60% <0.00%> (ø)
tx/textual/valuerenderer/bytes.go 53.84% <0.00%> (ø)
... and 32 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants