fix: make 46's linter work

[faddat]

Description

So, this is more or less the same scenario as the similar PR for 45-- the linter would always pass because we didn't check the repository out in lint.yml.

I'd like to recommend that in order to ensure that the linter runs, and to reduce ci complexity, we just use the canonical golangci-lint github action, that way we've less to maintain.

I've got to run to bed, but in both cases, if we want to fix this, I can.

If we think that the many minor changes this would cause would complicate the use of the sdk downstream, then maybe we should remove the lint.yml file from 45 & 46?

I really only figured this out because of work on Gaia and ibc-go, which used to have the same issue.

• no changelog entry since this does not change any internal or external APIs.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[alexanderbez]

I personally would like to fix linting in both 0.45 and 0.46

[faddat]

@alexanderbez If it's alright with you, I'd like to make a PR to main, that puts us on the canonical github action for gonalgci-lint.

I think that making our own has proven too complex and prone to breakage, I've fixed these issues:

• in the sdk
• in gaia
• in ibc-go

Each time it's had to do with either the usage of diff or checking out, and I think we can eliminate these issues, forever, by using the standard github action from the golangci-lint team.

[alexanderbez]

@faddat we don't really use our own. The reason we use the make target is to ensure each developer runs the same version of golangci-lint and that it doesn't get out of sync with what CI runs. I.e it's all consistent.

Why is this proving to be problematic?

[faddat]

We really do use our own.

Theirs:

• caches automatically
• works perfectly
• doesn't try to only lint diffs because the caching makes it run in a minute even on a large code base like this one

Ours:

• fires only when there's diffs, on files with diffs only not considering that a change in 1 file or package can cause changes in other files and packages
• suffers from issues because we run it conditionally based on the diffs
• isn't standardized or from the linter's team

https://golangci-lint.run/usage/integrations/

https://github.com/golangci/golangci-lint-action

Another way of putting it: the codebase hasn't been linted in years, nor had gaia's, nor had ibc-go's.

Initially I thought it was the git diffs.

Finally working with Billy on gaia, I realized that it was the checkout. But even when we check out, ours doesn't really do as good or as complete of a job and the git diff action isn't compatible with newer versions of git.

[alexanderbez]

I'm not following though. We're not using some custom linter -- we're using the native golangci-lint, we're just running it locally instead of the one GH action. So what I meant to say was, our linter is not custom. It's the exact same one.

Now based on your diff, I would suggest that we revise our jobs to perform the same as the action. If we cannot do this, then I propose that we:

• Use the action as you've proposed
• Write some script to ensure the action's linter version is always in line with the go.mod version

[faddat]

Ok indeed we're not using our own linter-- basically just our own github action. The golangci-lint team has put a lot of work into the action-- as for the versioning, can totally do it :D

Basically we would drop go tools and we would just add to the Makefile

go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest

And then we're all set!

(our jobs are fundamentally different from the canonical one, but we can surely make things match)

[alexanderbez]

That's fine with me! Note, we're not dropping go tools, just golangci-lint from go tools.

[faddat]

exactly. Ok, so I'll make that PR to main-- do you want me to update the 45 and 46 ones?

[alexanderbez]

yes, pls!

[faddat]

all set.

[julienrbrt]

Should we not add the same fix here too then: #13238?