Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sequence in sign-batch #13200

Merged
merged 13 commits into from
Sep 13, 2022
Merged

fix: sequence in sign-batch #13200

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
66416f1
fix `sign-batch`
atheeshp Sep 8, 2022
13e9121
Merge branch 'main' into ap/fix-sign-batch
atheeshp Sep 9, 2022
ae5b4b4
add changelog
atheeshp Sep 9, 2022
f189e0a
Merge branch 'ap/fix-sign-batch' of github.com:cosmos/cosmos-sdk into…
atheeshp Sep 9, 2022
98cc4e2
Merge branch 'main' into ap/fix-sign-batch
atheeshp Sep 9, 2022
be0fd14
fix tests
atheeshp Sep 9, 2022
b04d5ea
fix tests
atheeshp Sep 9, 2022
9fd1529
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/fix-sign-…
atheeshp Sep 9, 2022
007d826
Merge branch 'ap/fix-sign-batch' of github.com:cosmos/cosmos-sdk into…
atheeshp Sep 9, 2022
2cf815f
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/fix-sign-…
atheeshp Sep 13, 2022
9ea19d1
add tests
atheeshp Sep 13, 2022
3b58ea5
Merge branch 'main' into ap/fix-sign-batch
mergify[bot] Sep 13, 2022
17b6dbb
Merge branch 'main' into ap/fix-sign-batch
julienrbrt Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion x/auth/client/cli/tx_sign.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,22 @@ func makeSignBatchCmd() func(cmd *cobra.Command, args []string) error {
scanner := authclient.NewBatchScanner(txCfg, infile)

if !clientCtx.Offline {
txFactory = txFactory.WithAccountNumber(0).WithSequence(0)
from, err := cmd.Flags().GetString(flags.FlagFrom)
if err != nil {
return err
}

addr, _, _, err := client.GetFromFields(clientCtx, txFactory.Keybase(), from)
if err != nil {
return err
}

acc, err := txFactory.AccountRetriever().GetAccount(clientCtx, addr)
if err != nil {
return err
}

txFactory = txFactory.WithAccountNumber(acc.GetAccountNumber()).WithSequence(acc.GetSequence())
}

for sequence := txFactory.Sequence(); scanner.Scan(); sequence++ {
Expand Down