-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bring back filter logging #13236
Conversation
Codecov Report
@@ Coverage Diff @@
## main #13236 +/- ##
==========================================
- Coverage 55.87% 53.66% -2.22%
==========================================
Files 646 648 +2
Lines 54895 55342 +447
==========================================
- Hits 30675 29701 -974
- Misses 21762 23266 +1504
+ Partials 2458 2375 -83
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. Do we want to, in a follow up, use the tm logger everywhere that already depends on TM?
We're reverting #8072, is that right? |
Yup yup, i can leave the zero logger if needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK.
That PR has +200LOC, whereas this one only has -100. Did we remove all zerolog instances, or is there a follow-up #13236 (review) ?
I left cosmovisor untouched, we can migrate in another pr if we want. A lot of the changes were removing fmt.Sprintfs |
* bring back filter logging * fix build * remove zerologger * add changelog entry & docs * fix lint
Description
Closes: #XXXX
Todos:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change