Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring back filter logging #13236

Merged
merged 6 commits into from
Sep 12, 2022
Merged

feat: bring back filter logging #13236

merged 6 commits into from
Sep 12, 2022

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Sep 11, 2022

Description

Closes: #XXXX

Todos:

  • Docs
  • Changelog

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner September 11, 2022 15:00
@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #13236 (f064b4a) into main (4fe7797) will decrease coverage by 2.21%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13236      +/-   ##
==========================================
- Coverage   55.87%   53.66%   -2.22%     
==========================================
  Files         646      648       +2     
  Lines       54895    55342     +447     
==========================================
- Hits        30675    29701     -974     
- Misses      21762    23266    +1504     
+ Partials     2458     2375      -83     
Impacted Files Coverage Δ
baseapp/abci.go 67.01% <0.00%> (+2.59%) ⬆️
baseapp/baseapp.go 77.93% <ø> (+1.06%) ⬆️
baseapp/grpcrouter.go 90.00% <ø> (ø)
baseapp/grpcrouter_helpers.go 25.00% <ø> (ø)
baseapp/grpcserver.go 1.72% <ø> (ø)
baseapp/msg_service_router.go 85.29% <ø> (+4.41%) ⬆️
baseapp/options.go 69.23% <ø> (+0.71%) ⬆️
client/cmd.go 57.73% <0.00%> (ø)
client/context.go 54.49% <0.00%> (-1.79%) ⬇️
client/flags/flags.go 19.35% <ø> (-0.32%) ⬇️
... and 202 more

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Do we want to, in a follow up, use the tm logger everywhere that already depends on TM?

@amaury1093
Copy link
Contributor

We're reverting #8072, is that right?

@tac0turtle
Copy link
Member Author

tac0turtle commented Sep 12, 2022

We're reverting #8072, is that right?

Yup yup, i can leave the zero logger if needed

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

That PR has +200LOC, whereas this one only has -100. Did we remove all zerolog instances, or is there a follow-up #13236 (review) ?

@tac0turtle
Copy link
Member Author

tac0turtle commented Sep 12, 2022

I left cosmovisor untouched, we can migrate in another pr if we want. A lot of the changes were removing fmt.Sprintfs

@tac0turtle tac0turtle merged commit 855695d into main Sep 12, 2022
@tac0turtle tac0turtle deleted the marko/logger branch September 12, 2022 14:08
julienrbrt pushed a commit that referenced this pull request Sep 13, 2022
* bring back filter logging

* fix build

* remove zerologger

* add changelog entry & docs

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants