Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TxBytes from NewContext #1331

Merged
merged 2 commits into from
Jun 22, 2018
Merged

Remove TxBytes from NewContext #1331

merged 2 commits into from
Jun 22, 2018

Conversation

mossid
Copy link
Contributor

@mossid mossid commented Jun 21, 2018 •
edited
Loading

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated Gaia/Examples
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Closes: #1324

@mossid mossid requested a review from ebuchman as a code owner June 21, 2018 23:49
@cwgoes
Copy link
Contributor

cwgoes commented Jun 22, 2018

Why - were txBytes necessary at some point and are no longer? Might be useful to get the size of a transaction, although I agree that this shouldn't really be in the context.

@mossid
Copy link
Contributor Author

mossid commented Jun 22, 2018 •
edited
Loading

TxBytes still remains in Context, just removing it from NewContext. Ref: #1324 @cwgoes

@cwgoes
Copy link
Contributor

cwgoes commented Jun 22, 2018

TxBytes still remains in Context, just removing it from NewContext. Ref: #1324 @cwgoes

Ah misread, thanks.

cwgoes
cwgoes reviewed Jun 22, 2018
View reviewed changes
examples/democoin/x/assoc/validator_set.go Outdated
@@ -0,0 +1,105 @@
package assoc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed branch chaos.

cwgoes
cwgoes reviewed Jun 22, 2018
View reviewed changes
examples/democoin/x/assoc/validator_set_test.go Outdated
@@ -0,0 +1,71 @@
package assoc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file in this PR?

@codecov
Copy link

codecov bot commented Jun 22, 2018 •
edited
Loading

Codecov Report

Merging #1331 into develop will not change coverage.
The diff coverage is 75%.

@@           Coverage Diff           @@
##           develop   #1331   +/-   ##
=======================================
  Coverage     65.5%   65.5%           
=======================================
  Files          114     114           
  Lines         6305    6305           
=======================================
  Hits          4130    4130           
  Misses        1949    1949           
  Partials       226     226

cwgoes
cwgoes approved these changes Jun 22, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit ec6acda into develop Jun 22, 2018
@cwgoes cwgoes deleted the joon/1324-remove-txbytes branch June 22, 2018 01:03
adrianbrink pushed a commit that referenced this pull request Jul 2, 2018
@mossid
Merge PR #1331: Remove TxBytes from NewContext
83aed52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mossid @cwgoes