imp(keyring): improve UX for keyring.List #13369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
reviewed
Sep 23, 2022
…k into fedekunze/fix-keys-list
tac0turtle
approved these changes
Sep 23, 2022
tac0turtle
reviewed
Sep 23, 2022
|
Do we verify semantic commits now? Pretty sure |
Right, it wasn't https://github.com/cosmos/cosmos-sdk/actions/runs/3112841174/jobs/5046723158. The action isn't marked required however. |
I'd say we require it. I don't see a lot of harm in doing that |
|
I'm going to require it. |
|
Marked |
MissingNO57
added a commit
to fetchai/cosmos-sdk
that referenced
this pull request
Nov 30, 2022
## v0.45.9 - 2022-10-14 ATTENTION: This is a security release for the [Dragonberry security advisory](https://forum.cosmos.network/t/ibc-security-advisory-dragonberry/7702). All users should upgrade immediately. Users *must* add a replace directive in their go.mod for the new `ics23` package in the SDK: ``` replace ( github.com/confio/ics23/go => github.com/cosmos/cosmos-sdk/ics23 ) ``` ### Features * [#13435](cosmos/cosmos-sdk#13435) Extend error context when a simulation fails. ### Improvements * [#13369](cosmos/cosmos-sdk#13369) Improve UX for `keyring.List` by returning all retrieved keys. * [#13323](cosmos/cosmos-sdk#13323) Ensure `withdraw_rewards` rewards are emitted from all actions that result in rewards being withdrawn. * [#13321](cosmos/cosmos-sdk#13321) Add flag to disable fast node migration and usage. * (store) [#13326](cosmos/cosmos-sdk#13326) Implementation of ADR-038 file StreamingService, backport #8664. * (store) [#13540](cosmos/cosmos-sdk#13540) Default fastnode migration to false to prevent suprises. Operators must enable it, unless they have it enabled already. ### API Breaking Changes * (cli) [#13089](cosmos/cosmos-sdk#13089) Fix rollback command don't actually delete multistore versions, added method `RollbackToVersion` to interface `CommitMultiStore` and added method `CommitMultiStore` to `Application` interface. ### Bug Fixes * [#...](https://github.com/cosmos/cosmos-sdk/pull/) Implement dragonberry security patch. * For applying the patch please refer to the [RELEASE NOTES](./RELEASE_NOTES.md) * (store) [#13459](cosmos/cosmos-sdk#13459) Don't let state listener observe the uncommitted writes.
19 tasks
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
* imp(keyring): improve UX for keyring.List * use offline info in case of error * Delete .dccache * c++ * conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar implementation as #13207 but for
v0.45.x. This PR improves the UX for thekeyring listcommand by printing all the keys that have already been obtained.Ref: #10875
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change