Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove db #13370

Merged
merged 2 commits into from
Sep 23, 2022
Merged

refactor: remove db #13370

merged 2 commits into from
Sep 23, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 23, 2022

Description

  • Removes the db adapter from the cosmos-sdk

Reasoning: we're moving to https://github.com/cosmos/cosmos-db


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner September 23, 2022 12:30
@faddat faddat changed the title remove db !feat: remove db Sep 23, 2022
@faddat faddat changed the title !feat: remove db refactor: remove db Sep 23, 2022
@tac0turtle
Copy link
Member

we may still do something like this but for now its fine to movie it into a feature branch. already done (store/v2)

@tac0turtle tac0turtle merged commit 6cbb587 into cosmos:main Sep 23, 2022
@tac0turtle tac0turtle deleted the remove-db branch September 23, 2022 13:08
@faddat faddat mentioned this pull request Sep 23, 2022
19 tasks
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
* remove db

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants