fix: simapp sdk import

[faddat]

Description

cosmossdk.io/simapp didn't work anymore because it
imported a

github.com/cosmos/cosmos-sdk v0.0.0-0000000000

or such

Reproducing this issue

• attempt to port wasmd to sdk 47

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[odeke-em]

LGTM, thank you @faddat!

[tac0turtle]

We opted to leave this instead of updating the import each time. Can we still leave it?

[faddat]

Not if we want external apps to be able to use simapp

[faddat]

*maybe now that the version is fixed?

I'll check this out locally and let you know

[tac0turtle]

which external apps are using simapp? generally I don think anyone should be using simapp.

[faddat]

Interesting. Wasmd.

[julienrbrt]

I agree with Marko, the goal is to not have apps import simapp. If this is still required, this means we have forgotten something.

Firstly, looking at wasmd, it looks like we forgot to extract the App interface.
-> #13378

Investigating what we should do for the rest.

[julienrbrt]

See #13376 (comment)

[julienrbrt]

I think we can close this. Thank you, @faddat to have brought that to our attention.
We need to make sure apps do not need to import simapp. I will create an issue for it.