fix: double close #13400
Merged
fix: double close #13400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13400 +/- ##
==========================================
+ Coverage 54.40% 55.03% +0.62%
==========================================
Files 645 680 +35
Lines 54925 57835 +2910
==========================================
+ Hits 29881 31827 +1946
- Misses 22645 23342 +697
- Partials 2399 2666 +267
|
julienrbrt
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Pre-approving. Thank you! I'll rebase #13373 when this is merged then. Better indeed to split the upgrade and this fix.
CHANGELOG.md
Outdated
| @@ -1609,6 +1609,7 @@ sure you are aware of any relevant breaking changes. | |||
| * (client/keys) [#5091](https://github.com/cosmos/cosmos-sdk/issues/5091) `keys parse` does not honor client app's configuration. | |||
| * (x/bank) [#6674](https://github.com/cosmos/cosmos-sdk/pull/6674) Create account if recipient does not exist on handing `MsgMultiSend`. | |||
| * (x/auth) [#6287](https://github.com/cosmos/cosmos-sdk/pull/6287) Fix nonce stuck when sending multiple transactions from an account in a same block. | |||
| * (snapshot) [#13400](https://github.com/cosmos/cosmos-sdk/pull/13400) Fix snapshot checksum issue in golang 1.19. | |||
There was a problem hiding this comment.
Can you move the changelog under unreleased?
19 tasks
julienrbrt
approved these changes
Sep 27, 2022
alexanderbez
approved these changes
Sep 27, 2022
alexanderbez
approved these changes
Sep 27, 2022
ryanchristo
pushed a commit
to regen-network/cosmos-sdk
that referenced
this pull request
Dec 15, 2022
19 tasks
|
@tac0turtle, as discussed in Slack, then we'll need to backport this one in v0.45 and v0.46 along with the bump and the CometBFT migration. |
This was referenced Feb 20, 2023
julienrbrt
pushed a commit
that referenced
this pull request
Feb 24, 2023
19 tasks
mhofman
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Mar 8, 2023
(cherry picked from commit dcb0c9c)
mhofman
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Mar 23, 2023
(cherry picked from commit dcb0c9c)
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
(cherry picked from commit dcb0c9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #13373
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change