-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: specify module to export #13437
Conversation
Co-authored-by: @czarcas7ic <czarcas7ic@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13437 +/- ##
==========================================
- Coverage 54.10% 53.84% -0.27%
==========================================
Files 647 651 +4
Lines 55278 56386 +1108
==========================================
+ Hits 29910 30362 +452
- Misses 22970 23598 +628
- Partials 2398 2426 +28
|
types/module/module.go
Outdated
} | ||
} else { | ||
// verify modules exists in app, so that we don't panic in the middle of an export | ||
if err := m.checkModulesExists(modulesToExport); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, we cannot return a nice error in ExportCmd
as we don't have any information about the app. This does the job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we haven't released runtime yet, right? Hence no changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need a changelog due to the api breaking for export state
Added. |
feat!: specify module to export (cosmos#13437)
Description
Upstreams osmosis-labs#336 with extra checks.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change