Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: specify module to export #13437

Merged
merged 7 commits into from
Oct 4, 2022

Conversation

julienrbrt
Copy link
Member

Description

Upstreams osmosis-labs#336 with extra checks.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Co-authored-by: @czarcas7ic <czarcas7ic@users.noreply.github.com>
server/export.go Fixed Show fixed Hide fixed
server/export.go Fixed Show fixed Hide fixed
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #13437 (1b05ddb) into main (c2f0c0f) will decrease coverage by 0.26%.
The diff coverage is 78.94%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13437      +/-   ##
==========================================
- Coverage   54.10%   53.84%   -0.27%     
==========================================
  Files         647      651       +4     
  Lines       55278    56386    +1108     
==========================================
+ Hits        29910    30362     +452     
- Misses      22970    23598     +628     
- Partials     2398     2426      +28     
Impacted Files Coverage Δ
simapp/simd/cmd/root.go 70.35% <0.00%> (ø)
testutil/sims/simulation_helpers.go 17.14% <0.00%> (ø)
types/module/module.go 65.97% <86.66%> (-0.26%) ⬇️
simapp/export.go 11.94% <100.00%> (ø)
x/distribution/simulation/operations.go 80.64% <0.00%> (-9.68%) ⬇️
tx/textual/valuerenderer/int.go
tx/textual/valuerenderer/dec.go
tx/textual/valuerenderer/bytes.go
tx/textual/valuerenderer/coins.go
... and 13 more

@github-actions github-actions bot removed the Type: CI label Oct 3, 2022
}
} else {
// verify modules exists in app, so that we don't panic in the middle of an export
if err := m.checkModulesExists(modulesToExport); err != nil {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we cannot return a nice error in ExportCmd as we don't have any information about the app. This does the job.

@julienrbrt julienrbrt marked this pull request as ready for review October 3, 2022 20:55
@julienrbrt julienrbrt requested a review from a team as a code owner October 3, 2022 20:55
@alexanderbez alexanderbez changed the title feat: specify module to export feat!: specify module to export Oct 3, 2022
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we haven't released runtime yet, right? Hence no changelog?

types/module/module.go Show resolved Hide resolved
types/module/module.go Show resolved Hide resolved
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a changelog due to the api breaking for export state

@tac0turtle tac0turtle added the T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). label Oct 3, 2022
@julienrbrt
Copy link
Member Author

need a changelog due to the api breaking for export state

Added.

CHANGELOG.md Show resolved Hide resolved
Cashmaney pushed a commit to scrtlabs/cosmos-sdk that referenced this pull request Nov 29, 2022
Cashmaney added a commit to scrtlabs/cosmos-sdk that referenced this pull request Jan 17, 2023
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants