feat: let `sign-batch` read multiple files #13454

julienrbrt · 2022-10-05T21:24:27Z

Description

With this change, the command behaves identically when given multiple files or passed one file containing multiples transactions. Works with --append too.

$ simd tx sign-batch tx1.json tx2.json --from alice
# will return the same than
$ cat tx1.json > tx12.json
$ cat tx2.json >> tx12.json
$ simd tx sign-batch tx12.json --from alice

I believe it closes: #13066 without adding an extra command.

Refactored duplicated code too to improve readability.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

x/auth/client/tx.go

x/auth/client/cli/tx_sign.go

-		appendMessagesToSingleMsg, _ := cmd.Flags().GetBool(flagAppend)
-		if appendMessagesToSingleMsg {
-			// It will combine all tx msgs and create single signed transaction
+		appendMessagesToSingleTx, _ := cmd.Flags().GetBool(flagAppend)


codecov · 2022-10-05T21:34:03Z

Codecov Report

Merging #13454 (e90fa16) into main (2151427) will decrease coverage by 0.47%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13454      +/-   ##
==========================================
- Coverage   54.47%   54.00%   -0.48%     
==========================================
  Files         676      648      -28     
  Lines       57952    55429    -2523     
==========================================
- Hits        31570    29934    -1636     
+ Misses      23735    23094     -641     
+ Partials     2647     2401     -246

Impacted Files	Coverage Δ
x/auth/client/cli/tx_multisign.go	`0.00% <0.00%> (ø)`
x/auth/client/cli/tx_sign.go	`0.00% <0.00%> (ø)`
x/auth/client/tx.go	`30.84% <0.00%> (-5.83%)`	⬇️
orm/encoding/ormkv/seq.go
orm/model/ormtable/batch.go
orm/encoding/ormkv/unique_key.go
orm/encoding/ormkv/primary_key.go
orm/encoding/ormfield/bool.go
... and 39 more

alexanderbez

utACK 👏

ChienDuong · 2022-10-19T09:08:15Z

The how can I broadcast the combine singed_batch file?
I get the error: " cannot unmarshal object into Go value of type []uint8:"

Note:
i was succesfully do tx broadcast with tx sign

julienrbrt · 2022-10-19T13:26:06Z

I get the error: " cannot unmarshal object into Go value of type []uint8:"

Hey @ChienDuong, can you open an issue about it?
Stating which Cosmos SDK version you use, and the content of the file (anonymized if you want)?

ChienDuong · 2022-10-19T16:21:25Z

Let me clarify it @julienrbrt . If it can not be solved quickly I will open an issue.
What I normally do successfully:

Generate a transaction, then tx sign offline mode, then do "tx broadcast"
=> sometimes I face mismatch sequence error

Now I try:
Generate transaction, then sign with tx sign-batch offline mode, then do tx broadcast
I got the problem

Error: json: cannot unmarshal object into Go value of type []uint8: tx parse error

I found that the structure of the signed files between tx sign-batch and tx sign are differents. Thus, I can not broadcast successfully with tx sign-batch. I don't know how to broadcast tx sign-batch

tx sign-batch return 2 line

 {"signatures}:[{"public_key":... etc
 {"signatures}:[{"public_key":.... etc

tx sign return one line
{"body}:{"message"}:[{"@type": ....

alexanderbez · 2022-10-19T16:28:49Z

I found that the structure of the signed files between tx sign-batch and tx sign are differents. Thus, I can not broadcast successfully with tx sign-batch. I don't know how to broadcast tx sign-batch

@julienrbrt this doesn't sound right. Both should return/write a single JSON object with 1 or more messages and 1 or more signatures.

julienrbrt · 2022-10-19T16:33:55Z

Which version are you using? @ChienDuong

I'd rather move that to an issue tbh. Which specify the sdk version and steps to reproduce.

ChienDuong · 2022-10-19T16:37:57Z

More detail
tx sign-batch signs two transactions

{"signatures":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":""},"data":{"single":{"mode":"SIGN_MODE_DIRECT","signature":""}},"sequence":""}]}
{"signatures":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":""},"data":{"single":{"mode":"SIGN_MODE_DIRECT","signature":""}},"sequence":""}]}

tx sign only signs one transaction
{"body":{"messages":[{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"","to_address":"","amount":[{"denom":"","amount":""}]}],"memo":"","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":""},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":""}],"fee":{"amount":[],"gas_limit":"","payer":"","granter":""},"tip":null},"signatures":[""]}

I am using Cosmos SDK v0.46.x @julienrbrt

julienrbrt · 2022-10-19T16:38:56Z

Okay, can you reproduce building from main?

ChienDuong · 2022-10-19T16:55:47Z

Is there any way that I can DM you? @julienrbrt

julienrbrt · 2022-10-19T16:57:12Z

Is there any way that I can DM you? @julienrbrt

You can on discord julienrbrt#0001, but I am still advocating that you should open an issue (as you have this problem in 0.46 anyway)

ChienDuong · 2022-10-19T17:11:05Z

Many thanks @julienrbrt I just send you a friend request on discord. It is a bit complicated, thus I would like to DM you . I believe it will be real quick.

…

On Wed, 19 Oct 2022 at 23:57 Julien Robert ***@***.***> wrote: Is there any way that I can DM you? @julienrbrt <https://github.com/julienrbrt> You can on discord julienrbrt#0001, but I am still advocating that you should open an issue (as you have this problem in 0.46 anyway) — Reply to this email directly, view it on GitHub <#13454 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG3KD4FUGOOCXFIXKUJGURLWEAR7HANCNFSM6AAAAAAQ56B3J4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

feat: let sign-batch read multiple files

8cba168

julienrbrt requested a review from a team as a code owner October 5, 2022 21:24

github-actions bot added C:CLI C:x/auth labels Oct 5, 2022

github-advanced-security bot found potential problems Oct 5, 2022

View reviewed changes

julienrbrt added 2 commits October 5, 2022 23:32

add changelog

a903261

Merge branch 'main' into julien/authtx

7878582

julienrbrt added 3 commits October 6, 2022 00:06

fix gosec issue

a631cd6

simplify

40d5856

Merge branch 'main' into julien/authtx

194e401

alexanderbez approved these changes Oct 7, 2022

View reviewed changes

Merge branch 'main' into julien/authtx

e90fa16

julienrbrt enabled auto-merge (squash) October 7, 2022 14:58

julienrbrt merged commit 6efbedb into main Oct 7, 2022

julienrbrt deleted the julien/authtx branch October 7, 2022 15:12

LampardNguyen234 mentioned this pull request Aug 15, 2023

deps: bump cosmos-sdk v0.46 and evmos v12 AstraProtocol/astra#209

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: let `sign-batch` read multiple files #13454

feat: let `sign-batch` read multiple files #13454

julienrbrt commented Oct 5, 2022 •

edited

Loading

codecov bot commented Oct 5, 2022 •

edited

Loading

alexanderbez left a comment

ChienDuong commented Oct 19, 2022

julienrbrt commented Oct 19, 2022 •

edited

Loading

ChienDuong commented Oct 19, 2022 •

edited

Loading

alexanderbez commented Oct 19, 2022

julienrbrt commented Oct 19, 2022 •

edited

Loading

ChienDuong commented Oct 19, 2022 •

edited

Loading

julienrbrt commented Oct 19, 2022

ChienDuong commented Oct 19, 2022

julienrbrt commented Oct 19, 2022

ChienDuong commented Oct 19, 2022 via email •

edited

Loading

feat: let sign-batch read multiple files #13454

feat: let sign-batch read multiple files #13454

Conversation

julienrbrt commented Oct 5, 2022 • edited Loading

Description

Author Checklist

Reviewers Checklist

codecov bot commented Oct 5, 2022 • edited Loading

Codecov Report

alexanderbez left a comment

Choose a reason for hiding this comment

ChienDuong commented Oct 19, 2022

julienrbrt commented Oct 19, 2022 • edited Loading

ChienDuong commented Oct 19, 2022 • edited Loading

alexanderbez commented Oct 19, 2022

julienrbrt commented Oct 19, 2022 • edited Loading

ChienDuong commented Oct 19, 2022 • edited Loading

julienrbrt commented Oct 19, 2022

ChienDuong commented Oct 19, 2022

julienrbrt commented Oct 19, 2022

ChienDuong commented Oct 19, 2022 via email • edited Loading

feat: let `sign-batch` read multiple files #13454

feat: let `sign-batch` read multiple files #13454

julienrbrt commented Oct 5, 2022 •

edited

Loading

codecov bot commented Oct 5, 2022 •

edited

Loading

julienrbrt commented Oct 19, 2022 •

edited

Loading

ChienDuong commented Oct 19, 2022 •

edited

Loading

julienrbrt commented Oct 19, 2022 •

edited

Loading

ChienDuong commented Oct 19, 2022 •

edited

Loading

ChienDuong commented Oct 19, 2022 via email •

edited

Loading