ci: Update lint.yml and Makefile

[faddat]

Description

Yep, I hit it too. I think it is the difference between 1.49.0 and 1.50.0 in lint.yml and Makefile.

Also runs make format

NB: this PR touches what I consider to be the SDK's scariest file: the duct tape that holds together protocol buffers registrations, eg: fix_registration.go

Instead of attempting to fix any underlying issues, this just more effectively tells the linter not to mess about here.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[faddat]

ref: #13483

[julienrbrt]

Do you think it will resolve golangci flakiness? 🤔

We actually have set 1.49 in the Makefile too for consistency with CI. If we update we need to bump the version there too.

[julienrbrt]

Before merging we should update this: https://github.com/cosmos/cosmos-sdk/blob/main/Makefile#L358

[alexanderbez]

 Error: SA1019: desc.ExtendedType is deprecated: Use the ExtendedType method instead.  (staticcheck)
  Error: SA1019: desc.ExtensionType is deprecated: Use InterfaceOf(xt.Zero()) instead.  (staticcheck)
  Error: SA1019: desc.Field is deprecated: Use the Descriptor().Number method instead.  (staticcheck)
  Error: SA1019: desc.Name is deprecated: Use the Descriptor().FullName method instead.  (staticcheck)
  Error: SA1019: desc.Tag is deprecated: Do not use.  (staticcheck)
  Error: SA1019: desc.Filename is deprecated: Use Descriptor().ParentFile().Path() instead.  (staticcheck)

[faddat]

I'll get Makefile happy & the rest.

I still think that the version in Makefile and in CI should not be pinned as that'd make this pr unnecessary.

[faddat]

@alexanderbez basically those issues .... are from changes that @marbar3778 made, which removed those, as if we run with v1.49.0, they show as unnecessary. (the nolint statements on those lines)

[faddat]

Let's see if it still flags those.

[faddat]

oh, yes-- the scariest file in the sdk, fix_registration.go .....

[faddat]

@alexanderbez yup, there's a real deprecation issue in this file, and it should likely be refactored. Vinh on our team is pretty good with protobufs, you think I should ask him if he feels up to the task?

I'm also concerned that if we do touch anything, there could be copious ripple effects, and we may actually wish to use the deprecated style.

[codecov]

Codecov Report

Merging #13484 (d1fa622) into main (ad07de8) will increase coverage by 0.83%.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13484      +/-   ##
==========================================
+ Coverage   53.91%   54.75%   +0.83%     
==========================================
  Files         643      685      +42     
  Lines       55466    58767    +3301     
==========================================
+ Hits        29906    32178    +2272     
- Misses      23156    23895     +739     
- Partials     2404     2694     +290     

Impacted Files	Coverage Δ
server/grpc/gogoreflection/fix_registration.go	31.46% <0.00%> (ø)
tx/textual/valuerenderer/duration.go	78.40% <ø> (ø)
x/group/keeper/keeper.go	56.25% <0.00%> (-0.40%)	⬇️
orm/encoding/ormfield/int64.go	100.00% <0.00%> (ø)
orm/model/ormdb/json.go	66.66% <0.00%> (ø)
orm/encoding/ormfield/timestamp.go	76.31% <0.00%> (ø)
orm/model/ormtable/auto_increment.go	54.77% <0.00%> (ø)
orm/internal/fieldnames/fieldnames.go	100.00% <0.00%> (ø)
orm/encoding/ormfield/codec.go	90.56% <0.00%> (ø)
orm/encoding/ormfield/enum.go	80.00% <0.00%> (ø)
... and 35 more

[tac0turtle]

thank you