feat: overwrite default denom in init cmd
#13535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| genFile := config.GenesisFile() | ||
| overwrite, _ := cmd.Flags().GetBool(FlagOverwrite) | ||
| stakingBondDenom, _ := cmd.Flags().GetString(FlagStakingBondDenom) | ||
| defaultDenom, _ := cmd.Flags().GetString(FlagDefaultBondDenom) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13535 +/- ##
=======================================
Coverage 53.92% 53.92%
=======================================
Files 643 643
Lines 55475 55464 -11
=======================================
- Hits 29914 29910 -4
+ Misses 23158 23152 -6
+ Partials 2403 2402 -1
|
|
This is very useful, as every time we launch new chain we have to update genesis or app or config files manually or using jq/sed/dasel commands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#9776 is not so useful, as it changes only the default denomination for the staking module.
More modules use
sdk.DefaultBondDenom, such asgov, leading to a mix ofstakeand the chosen denomination.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change