-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add ApplicationQueryService release notes #13587
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,11 @@ | ||
| # Cosmos SDK v0.46.2 Release Notes | ||
| # Cosmos SDK v0.46.3 Release Notes | ||
|
|
||
| This release introduces a number of bug fixes, features and improvements. | ||
|
|
||
| Highlights: | ||
|
|
||
| + `ApplicationQueryService` was introduced to enable additional query service registration. Applications should implement `RegisterNodeService(client.Context)` method to automatically expose chain information query service implemented in [#13485](https://github.com/cosmos/cosmos-sdk/pull/13485). | ||
|
|
||
| Please see the [CHANGELOG](https://github.com/cosmos/cosmos-sdk/blob/release/v0.46.x/CHANGELOG.md) for an exhaustive list of changes. | ||
|
|
||
| **Full Commit History**: https://github.com/cosmos/cosmos-sdk/compare/v0.46.1...v0.46.2 | ||
| **Full Commit History**: https://github.com/cosmos/cosmos-sdk/compare/v0.46.2...v0.46.3 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can revert this. This won't be the highlight of v0.46.3 :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? The release notes should contain highlights of new things, and what developer should do. The feature is part of the release branch, so it will be part of the next release, unless we decide to rollback that feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but the release notes for this time focus only on dragonberry only (like 0.45.9).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then 0.46.3 will need to go to other branch, and once 46.4 will be released the RELEASE NOTES will have to be updated anyway. So I suggest to keep logical subsequent number, rather then keeping it in an "old" (46.2) state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean - if you want to do dragonbery release only then you need to fork from 0.46.2 and cp only relevant PRs. Otherwise need to be consistent with changelog and make sure other important updates are included in release notes.