Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [REDO] gRPC query for operator and chain configuration (backport #13485) #13589

Merged
merged 13 commits into from
Oct 18, 2022
Merged

feat: [REDO] gRPC query for operator and chain configuration (backport #13485) #13589

merged 13 commits into from
Oct 18, 2022

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Oct 18, 2022 •
edited
Loading

Description

#13498 was reverted or removed on 0.45.x. In addition, it introduces a Go API breaking change.

This PR redoes #13498 but without the API breaking change 🎉

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

alexanderbez and others added 6 commits October 10, 2022 19:13
@alexanderbez @mergify
feat: gRPC query for operator and chain configuration (#13485)
9c589b4 
(cherry picked from commit c60c556)

# Conflicts:
#	CHANGELOG.md
#	UPGRADING.md
#	api/cosmos/auth/v1beta1/query_grpc.pb.go
#	api/cosmos/bank/v1beta1/query.pulsar.go
#	runtime/app.go
#	server/start.go
#	simapp/app_legacy.go
#	x/auth/types/query.pb.go
#	x/bank/types/query.pb.go
@tac0turtle
fix conflicts
09cbc83
@tac0turtle
remove api module
242315c
@julienrbrt
make proto-gen
9430791
@julienrbrt
update changelog
a1c4017
@alexanderbez
updates
44addfd
@mergify mergify bot mentioned this pull request Oct 18, 2022
Merged
@alexanderbez alexanderbez marked this pull request as ready for review October 18, 2022 19:11
@alexanderbez alexanderbez requested a review from aaronc as a code owner October 18, 2022 19:11
@alexanderbez alexanderbez requested a review from a team October 18, 2022 19:15
tac0turtle
tac0turtle approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a upgrade.md entry

@alexanderbez
Copy link
Contributor Author

@tac0turtle we don't have an UPGRADING.md on 0.45.x :(

Should I add one?

tac0turtle
tac0turtle reviewed Oct 18, 2022
View reviewed changes
CHANGELOG.md Outdated
@@ -39,6 +39,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Features

* (grpc) [#13485](https://github.com/cosmos/cosmos-sdk/pull/13485) Implement a new gRPC query, `/cosmos/base/node/v1beta1/config`, which provides operator configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have no upgrading, can we get a shot sentence on how to add this to user apps

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Updated 👍

@alexanderbez alexanderbez enabled auto-merge (squash) October 18, 2022 22:45
@alexanderbez alexanderbez merged commit 7a500a2 into release/v0.45.x Oct 18, 2022
@alexanderbez alexanderbez deleted the mergify/bp/release/v0.45.x/pr-13485 branch October 18, 2022 22:54
amaury1093
amaury1093 reviewed Oct 19, 2022
View reviewed changes
proto/cosmos/base/node/v1beta1/query.proto
@@ -0,0 +1,22 @@
syntax = "proto3";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a since comment on the top of this file

SpicyLemon added a commit to provenance-io/cosmos-sdk that referenced this pull request Oct 24, 2022
@SpicyLemon @aaronc
@ValarDragon @julienrbrt @alexanderbez @nddeluca @mergify @gsk967
Apply v0.45.10 changes and prep changelog for v0.45.10-pio-1 (#318)
78cb115 
* fix: move ics23 to correct folder (cosmos#13549)

* fix: fix liveness tests cosmos#13551

* feat: add `GenSignedMockTx` (cosmos#13557)

* fix: fix `make proto-gen` (cosmos#13564)

* fix: fix `make proto-gen`

* add changelog

* feat: [REDO] gRPC query for operator and chain configuration (backport cosmos#13485) (cosmos#13589)

* chore: bump tendermint to `0.34.22` (cosmos#13585)

* fix: (v0.45.x) regression in return value of WithdrawDelegationRewards when rewards are zero (cosmos#13588)

* fix(server): v0.45.x Populate the PruningKeepEvery config entry in GetConfig. (cosmos#13610)

* Populate the PruningKeepEvery config entry in GetConfig.

* Update changlog.

* feat(cli): add module-account cli cmd and grpc get api (backport cosmos#13612) (cosmos#13617)

* feat(cli): add module-account cli cmd and grpc get api (cosmos#13612)

(cherry picked from commit ddf5cf0)

# Conflicts:
#	CHANGELOG.md
#	api/cosmos/auth/v1beta1/query.pulsar.go
#	api/cosmos/auth/v1beta1/query_grpc.pb.go
#	proto/cosmos/auth/v1beta1/query.proto
#	tests/e2e/auth/suite.go
#	x/auth/client/cli/query.go
#	x/auth/keeper/grpc_query.go
#	x/auth/keeper/grpc_query_test.go
#	x/auth/types/query.pb.go
#	x/auth/types/query.pb.gw.go

* update changelog

* fix conflicts

Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>

* chore: prepare 0.45.10 changelog (cosmos#13624)

* chore: prepare 0.45.10 changelog

* default release notes

* period

* Add missing changelog section for v0.45.9-pio-1.

* Remove the old release notes.

* Remove accidentally duplicated section for v0.45.4.

* Add new v0.45.10-pio-1 section to the changelog and update the release notes to reflect our stuff.

* Include a 'nothing' under unreleased.

* Add links to changlog entries.

Co-authored-by: Aaron Craelius <aaron@regen.network>
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com>
jaybxyz pushed a commit to cosmosquad-labs/cosmos-sdk that referenced this pull request Nov 1, 2022
@alexanderbez @jaybxyz
feat: [REDO] gRPC query for operator and chain configuration (backport …
f838104 
…cosmos#13485) (cosmos#13589)

(cherry picked from commit 7a500a2)
nnkken pushed a commit to likecoin/cosmos-sdk that referenced this pull request Nov 16, 2022
@alexanderbez @nnkken
feat: [REDO] gRPC query for operator and chain configuration (backport …
9992f93 
…cosmos#13485) (cosmos#13589)
@faddat faddat mentioned this pull request Dec 11, 2023
Draft
19 tasks
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@alexanderbez @JeancarloBarrios
feat: [REDO] gRPC query for operator and chain configuration (backport …
66ea2c2 
…cosmos#13485) (cosmos#13589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@amaury1093 amaury1093 amaury1093 left review comments

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

Assignees
No one assigned
Labels
C:CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexanderbez @amaury1093 @tac0turtle @julienrbrt