feat(core): add ADR 033 (inter-module communication) Client interface

[aaronc]

Description

Ref #9238

This adds the ADR 033 intermodule.Client interface implemented in #13519 to core. #13519 has gotten rather large so I am breaking it up.

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[tac0turtle]

this is fine to merge but I think we need to figure out a migration path, having users rewrite modules at once to take advantage of this feature is a no go

[aaronc]

this is fine to merge but I think we need to figure out a migration path, having users rewrite modules at once to take advantage of this feature is a no go

What migration are you talking about? Deprecating MsgServiceRouter? Only modules that use that would need to be modified

[tac0turtle]

was thinking how to do this without migrating away from keeper for some people, we can do a handler path, but its stilll unclear to me which is more work. something we can discover on the fly

[aaronc]

was thinking how to do this without migrating away from keeper for some people, we can do a handler path, but its stilll unclear to me which is more work. something we can discover on the fly

Yeah we don't need to commit to any migration now. We can deal with that all later and there are multiple options. Enabling ADR 033 just makes it usable for modules, not required

[alexanderbez]

🐉

[codecov]

Codecov Report

Merging #13631 (1c1c56b) into main (ad08ec4) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13631      +/-   ##
==========================================
+ Coverage   54.69%   54.76%   +0.06%     
==========================================
  Files         645      647       +2     
  Lines       55745    55873     +128     
==========================================
+ Hits        30491    30598     +107     
- Misses      22764    22780      +16     
- Partials     2490     2495       +5     

Impacted Files	Coverage Δ
crypto/keys/internal/ecdsa/privkey.go	81.13% <0.00%> (-1.89%)	⬇️
core/appconfig/config.go	76.71% <0.00%> (ø)
core/coins/format.go	83.63% <0.00%> (ø)
x/staking/simulation/operations.go	75.91% <0.00%> (+1.37%)	⬆️

[aaronc]

Tagging core/v0.3.2 with this