refactor!: Add context arg to sign mode handler GetSignBytes

[amaury1093]

Description

Closes: #13646

The context.Context arg is set in this PR:

• to sdk.WrapContext(sdkCtx) in antehandler code
• to nil in tests where we know Textual won't be used
• to context.TODO() in client code, where we need to update the wiring to pass a context.Context, to be tackled in Allow client-side signing with SIGN_MODE_TEXTUAL  #13747

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #13701 (bec1699) into main (2739f83) will decrease coverage by 0.25%.
The diff coverage is 65.38%.

❗ Current head bec1699 differs from pull request most recent head 4dd06b0. Consider uploading reports for the commit 4dd06b0 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13701      +/-   ##
==========================================
- Coverage   56.25%   56.00%   -0.26%     
==========================================
  Files         667      666       -1     
  Lines       56576    57916    +1340     
==========================================
+ Hits        31829    32435     +606     
- Misses      22165    22843     +678     
- Partials     2582     2638      +56     

Impacted Files	Coverage Δ
testutil/sims/tx_helpers.go	0.00% <0.00%> (ø)
x/auth/client/tx.go	30.84% <0.00%> (ø)
x/auth/tx/direct_aux.go	83.78% <ø> (ø)
client/tx/tx.go	33.57% <50.00%> (ø)
simapp/simd/cmd/testnet.go	62.08% <50.00%> (ø)
x/auth/client/cli/tx_multisign.go	29.23% <50.00%> (+0.12%)	⬆️
tools/rosetta/converter.go	56.75% <100.00%> (ø)
x/auth/ante/sigverify.go	66.99% <100.00%> (ø)
x/auth/client/cli/validate_sigs.go	80.20% <100.00%> (+0.20%)	⬆️
x/auth/migrations/legacytx/amino_signing.go	63.82% <100.00%> (ø)
... and 74 more

[tac0turtle]

utACK. could we have an upgrading.md entry as many teams have to fork our ante handlers to add ibc ones. Also do we want this in 0.47? or can it wait for an alpha to be cut then merged?

[amaury1093]

Yeah i'm fine to wait for a 0.47 release branch, but maybe in 2 weeks this will start blocking textual work

[amaury1093]

Putting as draft so it doesn't get merged accidentally

[julienrbrt]

This seems to be blocked on a vulnerability unrelated to this PR: https://github.com/cosmos/cosmos-sdk/actions/runs/3487690117

[amaury1093]

I'll fix conflicts and try to have another look at the btc dep

[sonarqubecloud]

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

82.4% Coverage
0.0% Duplication

[sonarqubecloud]

[Cosmos SDK - SimApp] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information