Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: file base genesis source/target #13724
feat: file base genesis source/target #13724
Changes from all commits
f2fb040
aacb158
5cef410
0aa3faf
0271aa2
9793747
6338347
61704a6
a7b4c7a
885b92f
17fdaf5
cde16b7
c41e73e
e26e2ed
224468b
b8b0d9a
274e49b
194bf29
087e8a1
c98dbc7
fa6e0fa
8d4047d
e65f2fd
7471cc1
be088da
5fec7b8
b8d7e4e
416df26
32e5ae6
119c31d
2ffc074
51ce71e
e15e2f1
d350663
e7b5dce
ad0193b
f316228
fafd034
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should default to the json coming from initchain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I updated it to return the default rawJson when the file doesn't exist. If we have an error during the file reading, we should return the error directly I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense