Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove client/keys.KeysCdc #13781

Merged
merged 4 commits into from
Nov 9, 2022
Merged

refactor: Remove client/keys.KeysCdc #13781

merged 4 commits into from
Nov 9, 2022

Conversation

jacobhjkim
Copy link

@jacobhjkim jacobhjkim commented Nov 7, 2022

Description

Closes: #8047

Replace client/keys.KeysCdc with encoding/json.

  • I have tested CLI JSON outputs between client/keys.KeysCdc and encoding/json. The output doesn't seem to change at all.
  • Deleted unused client.keys/codec.go and client.keys/codec_test.go.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@jacobhjkim jacobhjkim requested a review from a team as a code owner November 7, 2022 12:59
@github-actions github-actions bot added C:CLI C:Keys Keybase, KMS and HSMs labels Nov 7, 2022
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, reviewed all the structs where we switched from amino to std json, and their outputs should be the same

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #13781 (99fbbf6) into main (22f3261) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13781      +/-   ##
==========================================
- Coverage   56.71%   56.70%   -0.01%     
==========================================
  Files         636      635       -1     
  Lines       54556    54547       -9     
==========================================
- Hits        30940    30932       -8     
+ Misses      21110    21109       -1     
  Partials     2506     2506              
Impacted Files Coverage Δ
client/keys/add.go 63.34% <0.00%> (ø)
client/keys/parse.go 77.01% <0.00%> (ø)
client/keys/utils.go 27.08% <0.00%> (+0.55%) ⬆️

@julienrbrt julienrbrt enabled auto-merge (squash) November 9, 2022 06:37
@julienrbrt julienrbrt merged commit f8e40d7 into cosmos:main Nov 9, 2022
@jacobhjkim jacobhjkim deleted the issue-8047 branch November 9, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove client/keys.KeysCdc
4 participants