Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove gogoproto stringer annotations and MarshalYAML functions #13850

Merged
merged 25 commits into from
Nov 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
93831c0
fix: bump gogoproto and fix tests mentioning #10965
julienrbrt Nov 14, 2022
67ac3fd
updates
julienrbrt Nov 14, 2022
d0f0e1d
`make proto-gen` again
julienrbrt Nov 14, 2022
3a7a2a9
updates
julienrbrt Nov 14, 2022
c861389
Merge branch 'main' into julien/bump-gogoproto
julienrbrt Nov 16, 2022
64db167
e.g of less human-readable string
julienrbrt Nov 16, 2022
65e7f8b
updates
julienrbrt Nov 16, 2022
fb0e230
migrate modules
julienrbrt Nov 16, 2022
cea5002
Revert "migrate modules"
julienrbrt Nov 16, 2022
3b3eeaa
split modules migrations
julienrbrt Nov 16, 2022
6fe2374
Merge branch 'main' into julien/bump-gogoproto
julienrbrt Nov 16, 2022
82734b2
Merge branch 'main' into julien/bump-gogoproto
julienrbrt Nov 17, 2022
84906ac
Merge branch 'main' into julien/bump-gogoproto
julienrbrt Nov 18, 2022
06a7d61
updates
julienrbrt Nov 18, 2022
aac0a14
Merge branch 'main' into julien/bump-gogoproto
julienrbrt Nov 21, 2022
fa77fc1
Merge branch 'main' into julien/bump-gogoproto
julienrbrt Nov 23, 2022
220d639
`make proto-gen`
julienrbrt Nov 23, 2022
0a37f03
Merge branch 'main' into julien/bump-gogoproto
julienrbrt Nov 23, 2022
0206892
feedback
julienrbrt Nov 23, 2022
c359074
Merge branch 'main' into julien/bump-gogoproto
julienrbrt Nov 25, 2022
1763fe9
`make proto-gen`
julienrbrt Nov 25, 2022
7c03bab
Merge branch 'main' into julien/bump-gogoproto
tac0turtle Nov 27, 2022
8a20880
Merge branch 'main' into julien/bump-gogoproto
tac0turtle Nov 27, 2022
d872a2a
add changelog and upgrading.md
julienrbrt Nov 28, 2022
2ce9cbb
Merge branch 'main' into julien/bump-gogoproto
julienrbrt Nov 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### API Breaking Changes

* (x/auth) [#13850](https://github.com/cosmos/cosmos-sdk/pull/13850/) Remove `MarshalYAML` methods from module (`x/...`) types.
* (x/auth) [#13877](https://github.com/cosmos/cosmos-sdk/pull/13877) Rename `AccountKeeper`'s `GetNextAccountNumber` to `NextAccountNumber`.
* (x/evidence) [#13740](https://github.com/cosmos/cosmos-sdk/pull/13740) The `NewQueryEvidenceRequest` function now takes `hash` as a HEX encoded `string`.
* (server) [#13485](https://github.com/cosmos/cosmos-sdk/pull/13485) The `Application` service now requires the `RegisterNodeService` method to be implemented.
Expand Down Expand Up @@ -186,7 +187,7 @@ extension interfaces. `module.Manager.Modules` is now of type `map[string]interf

* (x/upgrade) [#13936](https://github.com/cosmos/cosmos-sdk/pull/13936) Make downgrade verification work again
* (x/group) [#13742](https://github.com/cosmos/cosmos-sdk/pull/13742) Fix `validate-genesis` when group policy accounts exist.
* (x/auth) [#13838](https://github.com/cosmos/cosmos-sdk/pull/13838) Fix calling `String()` and `MarshalYAML` panics when pubkey is set on a `BaseAccount`.
* (x/auth) [#13838](https://github.com/cosmos/cosmos-sdk/pull/13838) Fix calling `String()` when pubkey is set on a `BaseAccount`.
* (rosetta) [#13583](https://github.com/cosmos/cosmos-sdk/pull/13583) Misc fixes for cosmos-rosetta.
* (x/evidence) [#13740](https://github.com/cosmos/cosmos-sdk/pull/13740) Fix evidence query API to decode the hash properly.
* (bank) [#13691](https://github.com/cosmos/cosmos-sdk/issues/13691) Fix unhandled error for vesting account transfers, when total vesting amount exceeds total balance.
Expand Down
9 changes: 9 additions & 0 deletions UPGRADING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@ This guide provides instructions for upgrading to specific versions of Cosmos SD

## [Unreleased]

### Protobuf

The SDK is in the process of removing all `gogoproto` annotations.

### Stringer

The `Stringer` implementation of some packages use `proto.CompactTextString` for _stringify_ a struct.
Please [verify](https://github.com/cosmos/cosmos-sdk/pull/13850#issuecomment-1328889651) the usage of the `.String()` method in your application. An chain should not rely on it for any state-machine related operation.

## [v0.47.x](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.47.0)

### Simulation
Expand Down
92 changes: 46 additions & 46 deletions api/cosmos/auth/v1beta1/auth.pulsar.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading