-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: register sdk metrics on startInProcess #13997
Conversation
Maybe I am doing something wrong, but if I try the current main vs your fix, I see no difference. |
@julienrbrt you will always see Tendermint metrics. The issue is with metrics extended by applications. Use the following config on both tries
Try the next stteps locally with both version to reproduce:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why moving the SetTelemetry
call within Server#Start
fixes the bug?
Also, if we're removing the mutex from SetTelemetry
then I don't feel comfortable about having it be public. The caller has no idea wether if/when it's safe to call it.
Also, changelog :p
I am honestly not entirely sure why this fixes the bug. I went through the changes on #12448 and from first observation, it didnt seem to have anything wrong. The only thing I knew was that before this PR things were working correctly (as I had tested locally using the steps I mentioned earlier). I tried different combinations and realized that the only way it works as expected is by setting Telemetry inside of the |
Updated Changelog and made |
Let's wait, if we are merging, after the investigation of OP (#13982 (comment)) |
Closing this as it is an issue on Evmos as explained here! - #13982 (comment). |
Description
closes #13982
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change