-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add docs about x/auth/tx
#14021
Conversation
@@ -46,7 +46,7 @@ import ( | |||
sdk "github.com/cosmos/cosmos-sdk/types" | |||
moduletestutil "github.com/cosmos/cosmos-sdk/types/module/testutil" | |||
_ "github.com/cosmos/cosmos-sdk/x/auth" | |||
_ "github.com/cosmos/cosmos-sdk/x/auth/tx/module" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really relevant here, but I think we should move this out of auth in the future. It's weird that all modules rely on auth because of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see my comment on Slack :)
missing a changelog for the import changes |
I don't think we need a changelog because we didn't release 0.47 final. Do we need a changelog for differences between alpha vs beta/final? |
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed! |
* docs: add docs about `x/auth/tx` * updates * updates * updates * updates * updates * updates * updates Co-authored-by: Marko <marbar3778@yahoo.com> (cherry picked from commit 6f329d7) # Conflicts: # api/cosmos/auth/v1beta1/query.pulsar.go # go.sum # simapp/go.sum # tests/go.sum # x/auth/types/query.pb.go
* docs: add docs about `x/auth/tx` (#14021) * docs: add docs about `x/auth/tx` * updates * updates * updates * updates * updates * updates * updates Co-authored-by: Marko <marbar3778@yahoo.com> (cherry picked from commit 6f329d7) # Conflicts: # api/cosmos/auth/v1beta1/query.pulsar.go # go.sum # simapp/go.sum # tests/go.sum # x/auth/types/query.pb.go * bump deps (#14035) * updates * updates Co-authored-by: Julien Robert <julien@rbrt.fr>
* docs: add docs about `x/auth/tx` * updates * updates * updates * updates * updates * updates * updates Co-authored-by: Marko <marbar3778@yahoo.com>
Description
Closes #13812
x/auth/tx
x/auth/tx/module
tox/auth/tx/config
asauthtx
isn't a module"github.com/cosmos/cosmos-sdk/x/auth/testutilhelpers/tx"
to"github.com/cosmos/cosmos-sdk/x/auth/tx/testutil"
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change