Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs about x/auth/tx #14021

Merged
merged 13 commits into from
Nov 27, 2022
Merged

docs: add docs about x/auth/tx #14021

merged 13 commits into from
Nov 27, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Nov 25, 2022

Description

Closes #13812

  • Add docs about x/auth/tx
  • Rename x/auth/tx/module to x/auth/tx/config as authtx isn't a module
  • Move "github.com/cosmos/cosmos-sdk/x/auth/testutilhelpers/tx" to "github.com/cosmos/cosmos-sdk/x/auth/tx/testutil"

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review November 25, 2022 14:44
@julienrbrt julienrbrt requested review from tac0turtle and a team as code owners November 25, 2022 14:44
@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Nov 25, 2022
@@ -46,7 +46,7 @@ import (
sdk "github.com/cosmos/cosmos-sdk/types"
moduletestutil "github.com/cosmos/cosmos-sdk/types/module/testutil"
_ "github.com/cosmos/cosmos-sdk/x/auth"
_ "github.com/cosmos/cosmos-sdk/x/auth/tx/module"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really relevant here, but I think we should move this out of auth in the future. It's weird that all modules rely on auth because of this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see my comment on Slack :)

@tac0turtle
Copy link
Member

missing a changelog for the import changes

@julienrbrt
Copy link
Member Author

missing a changelog for the import changes

I don't think we need a changelog because we didn't release 0.47 final. Do we need a changelog for differences between alpha vs beta/final?

@sonarcloud
Copy link

sonarcloud bot commented Nov 27, 2022

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.7% 91.7% Coverage
0.0% 0.0% Duplication

@julienrbrt julienrbrt enabled auto-merge (squash) November 27, 2022 19:22
@julienrbrt julienrbrt merged commit 6f329d7 into main Nov 27, 2022
@julienrbrt julienrbrt deleted the julien/docs-authtx branch November 27, 2022 20:30
mergify bot pushed a commit that referenced this pull request Nov 27, 2022
* docs: add docs about `x/auth/tx`

* updates

* updates

* updates

* updates

* updates

* updates

* updates

Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 6f329d7)

# Conflicts:
#	api/cosmos/auth/v1beta1/query.pulsar.go
#	go.sum
#	simapp/go.sum
#	tests/go.sum
#	x/auth/types/query.pb.go
@julienrbrt julienrbrt mentioned this pull request Nov 27, 2022
19 tasks
tac0turtle pushed a commit that referenced this pull request Nov 27, 2022
* docs: add docs about `x/auth/tx` (#14021)

* docs: add docs about `x/auth/tx`

* updates

* updates

* updates

* updates

* updates

* updates

* updates

Co-authored-by: Marko <marbar3778@yahoo.com>
(cherry picked from commit 6f329d7)

# Conflicts:
#	api/cosmos/auth/v1beta1/query.pulsar.go
#	go.sum
#	simapp/go.sum
#	tests/go.sum
#	x/auth/types/query.pb.go

* bump deps (#14035)

* updates

* updates

Co-authored-by: Julien Robert <julien@rbrt.fr>
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* docs: add docs about `x/auth/tx`

* updates

* updates

* updates

* updates

* updates

* updates

* updates

Co-authored-by: Marko <marbar3778@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: create x/auth/tx docs
2 participants