Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more context for errors when no address is provided #1404

Merged
merged 2 commits into from
Jun 27, 2018

Conversation

ValarDragon
Copy link
Contributor

The current error message isn't that helpful.

  • Updated all relevant documentation in docs - n/a
  • Updated all code comments where relevant - n/a
  • Wrote tests
  • Updated CHANGELOG.md - should this update the changelog, seems pretty minor?
  • Updated Gaia/Examples
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes
Copy link
Contributor

cwgoes commented Jun 27, 2018

Is the CI failure related to these changes?

@codecov
Copy link

codecov bot commented Jun 27, 2018

Codecov Report

Merging #1404 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1404   +/-   ##
========================================
  Coverage    62.81%   62.81%           
========================================
  Files          109      109           
  Lines         6016     6016           
========================================
  Hits          3779     3779           
  Misses        2020     2020           
  Partials       217      217

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ValarDragon
Copy link
Contributor Author

test unit passes on my machine

@cwgoes cwgoes merged commit 3dc2387 into develop Jun 27, 2018
@cwgoes cwgoes deleted the dev/update_error_msg branch June 27, 2018 17:40
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants