refactor: remove gogoproto stringer annotations

[julienrbrt]

Description

Follow-up of #13850
See #13850 (review), #13850 (comment)

These are left because I am not sure of the impact.

• https://github.com/cosmos/cosmos-sdk/blob/main/proto/cosmos/base/store/v1beta1/commit_info.proto#L25
• crypto packages

It seems like the Capability annotations needs to stay:

// String returns the string representation of a Capability. The string contains
// the Capability's memory reference as the string is to be used in a composite
// key and to authenticate capabilities.
func (ck *Capability) String() string {
	return fmt.Sprintf("Capability{%p, %d}", ck, ck.Index)
}

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[facundomedica]

LGTM, I think that the capability String() is safe to remove, the comment is a bit ambiguous and also wrong as of the latest version of FwdCapabilityKey.

The string contains the Capability's memory reference as the string is to be used in a composite key and to authenticate capabilities.

I think this is just saying "we return this memory reference because it's useful for debugging or whatever, given that we use it to create a key somewhere else". That key would be FwdCapabilityKey and the format used is outdated; FwdCapabilityKey now uses %#016p (since v0.46.0 iirc) instead of %p like here.

cosmos-sdk/x/capability/types/keys.go

Lines 39 to 43 in 121ae53

	// FwdCapabilityKey returns a forward lookup key for a given module and capability
	// reference.
	func FwdCapabilityKey(module string, cap *Capability) []byte {
	return []byte(fmt.Sprintf("%s/fwd/%#016p", module, cap))
	}

btw most likely my bad that the format of String() and FwdCapabilityKey don't match 😅 (my first PR in the SDK lol)

[sonarcloud]

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

93.3% Coverage
0.0% Duplication

[amaury1093]

LGTM, thanks

[facundomedica]

LGTM! 🚀