improve cli flags #142
Merged
improve cli flags #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2017
ethanfrey
force-pushed
the
feature/130-support-tendermint-flags
branch
from
0e67f60
to
e37c0cf
Compare
ebuchman
reviewed
Jun 26, 2017
| @@ -1,5 +1,28 @@ | |||
| # Changelog | |||
|
|
|||
| ## 0.6.1 (TBD) | |||
cmd/basecli/commands/cmds.go
Outdated
| @@ -47,6 +47,9 @@ func init() { | |||
|
|
|||
| // runDemo is an example of how to make a tx | |||
| func doSendTx(cmd *cobra.Command, args []string) error { | |||
| if err := commands.RequireInit(cmd); err != nil { | |||
There was a problem hiding this comment.
Done and done. :)
| @@ -23,7 +23,7 @@ test00GetAccount() { | |||
|
|
|||
| checkAccount $SENDER "0" "9007199254740992" | |||
|
|
|||
| ACCT2=$(${CLIENT_EXE} query account $RECV) | |||
| ACCT2=$(${CLIENT_EXE} query account $RECV 2>/dev/null) | |||
There was a problem hiding this comment.
Why pipe to dev/null when we want the output ?
There was a problem hiding this comment.
It is supposed to fail. And I want no output on failure.
Rigel changed so all errors go to stderr. So unless I want lots of error messages in a successful test, I have to do this if the next line is assertFalse $?
| @@ -23,7 +23,7 @@ test00GetAccount() { | |||
|
|
|||
| checkAccount $SENDER "0" "9007199254740992" | |||
|
|
|||
| ACCT2=$(${CLIENT_EXE} query account $RECV) | |||
| ACCT2=$(${CLIENT_EXE} query account $RECV 2>/dev/null) | |||
liamsi
pushed a commit
to liamsi/cosmos-sdk
that referenced
this pull request
Jun 26, 2018
ParthDesai
pushed a commit
to ChorusOne/cosmos-sdk
that referenced
this pull request
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes up a number of issues with the cli tools, to make it easier to used based on testnet feedback.
Fixes:
#130
#113
#135
#137