-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix race conditions from #14332 #14402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK.
cc @alpe for visibility
any chance we could get a complex test case showing a module with the interface and one without and see how its handled |
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed! |
That is basically testing interface check of Go. Do you think it's really useful? |
Description
Closes: #14389
ref: #14332
We are already testing in
TestManager_ExportGenesis
, just adding one test case.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change