Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gov): don't export deprecated params #14408

Merged
merged 4 commits into from
Dec 24, 2022
Merged

fix(gov): don't export deprecated params #14408

merged 4 commits into from
Dec 24, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Dec 23, 2022

Description

ref: #14358, #14093 (comment)

Checked migrate genesis that works properly from a 0.46 genesis vs 0.47 genesis.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner December 23, 2022 22:34
@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Dec 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2022

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tac0turtle tac0turtle merged commit bc46bbb into main Dec 24, 2022
@tac0turtle tac0turtle deleted the julien/gov branch December 24, 2022 14:21
mergify bot pushed a commit that referenced this pull request Dec 24, 2022
tac0turtle pushed a commit that referenced this pull request Dec 24, 2022
Co-authored-by: Julien Robert <julien@rbrt.fr>
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @julienrbrt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants