fix: add block height to prepareProposal context #14467
Conversation
EDIT: This seems to be another flaky test |
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!
|
| if app.prepareProposal == nil { | ||
| panic("PrepareProposal method not set") | ||
| } | ||
|
|
||
| ctx := app.getContextForTx(runTxPrepareProposal, []byte{}). | ||
| WithBlockHeight(req.Height). |
There was a problem hiding this comment.
This seems to be set to a valid value after the first PrepareProposal call. Do you know why this might be happening?
There was a problem hiding this comment.
Late response, but this was happening because you would be seeing the previous block height instead of the current. So it gave the illusion of being a valid value
| @@ -289,13 +293,11 @@ func (app *BaseApp) ProcessProposal(req abci.RequestProcessProposal) (resp abci. | |||
| panic("app.ProcessProposal is not set") | |||
| } | |||
|
|
|||
| ctx := app.processProposalState.ctx. | |||
There was a problem hiding this comment.
here and below: for my own understanding, why do we stop populating VoteInfo, Proposer and ConsensusParam?
There was a problem hiding this comment.
Those are being set inside getContextForTx, just a little cleanup to reuse code (although not really happy about it, as the function is intended to create a context for a single tx afaik; might roll this back for readability).
| Height: req.Height, | ||
| ProposerAddress: req.ProposerAddress, | ||
| } | ||
| app.setState(runTxModeDeliver, initHeader) |
There was a problem hiding this comment.
Let's update setState to also accept runTxPrepareProposal for deliver state.
i.e. case runTxModeDeliver, runTxPrepareProposal: ...
|
Closing in favor of #14505 |
Description
Ref: #14446
Audit: #13951
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change