Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mempool): priority nonce mempool option with tx replacement #14484

Merged
merged 12 commits into from
Jan 10, 2023

Conversation

JayT106
Copy link
Contributor

@JayT106 JayT106 commented Jan 4, 2023

Description

Add a mempool option for app setup of the tx replacement rule based on tx priority comparing logic. The current implementation is always allowing the transaction to be replaced when the mempool has a transaction with the same sender and the nonce.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JayT106 JayT106 requested a review from a team as a code owner January 4, 2023 20:45
@JayT106 JayT106 changed the title feat: priority nonce mempool option with tx replacement feat(mempool): priority nonce mempool option with tx replacement Jan 4, 2023
@kocubinski kocubinski self-assigned this Jan 5, 2023
@kocubinski
Copy link
Member

So the intent here is to disallow tx replacement by [sender, nonce] by an arbitrary rule defined by the user of the mempool?

@JayT106
Copy link
Contributor Author

JayT106 commented Jan 5, 2023

So the intent here is to disallow tx replacement by [sender, nonce] by an arbitrary rule defined by the user of the mempool?

Correct, the application can setup a rule to replace the transaction when the transaction has the same sender&nonce instead of always being replaced.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Can we add a changelog?

@JayT106
Copy link
Contributor Author

JayT106 commented Jan 10, 2023

lgtm!

Can we add a changelog?

done!

@julienrbrt julienrbrt merged commit e6b849a into cosmos:main Jan 10, 2023
0xmuralik pushed a commit to 0xmuralik/cosmos-sdk that referenced this pull request Jan 12, 2023
@alexanderbez
Copy link
Contributor

@Mergifyio backport release/v0.47.x

@mergify
Copy link
Contributor

mergify bot commented Feb 22, 2023

backport release/v0.47.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 22, 2023
)

Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
(cherry picked from commit e6b849a)

# Conflicts:
#	CHANGELOG.md
alexanderbez pushed a commit that referenced this pull request Feb 22, 2023
…kport #14484) (#15126)

Co-authored-by: JayT106 <JayT106@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants