-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mempool): priority nonce mempool option with tx replacement #14484
feat(mempool): priority nonce mempool option with tx replacement #14484
Conversation
So the intent here is to disallow tx replacement by |
Correct, the application can setup a rule to replace the transaction when the transaction has the same sender&nonce instead of always being replaced. |
Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Can we add a changelog?
done! |
…mos#14484) Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
@Mergifyio backport release/v0.47.x |
✅ Backports have been created
|
) Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> (cherry picked from commit e6b849a) # Conflicts: # CHANGELOG.md
Description
Add a mempool option for app setup of the tx replacement rule based on tx priority comparing logic. The current implementation is always allowing the transaction to be replaced when the mempool has a transaction with the same sender and the nonce.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change