-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove default iavl-cache-size invalid value #14486
Merged
alexanderbez
merged 4 commits into
cosmos:main
from
mdumais-stratos:mdumais/11382-iavl-cache-size-docs-update
Jan 5, 2023
Merged
docs: remove default iavl-cache-size invalid value #14486
alexanderbez
merged 4 commits into
cosmos:main
from
mdumais-stratos:mdumais/11382-iavl-cache-size-docs-update
Jan 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienrbrt
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
likhita-809
approved these changes
Jan 5, 2023
the default here https://github.com/cosmos/cosmos-sdk/blob/main/store/iavl/store.go#L25 is probably what we should also change to be smaller |
alexanderbez
approved these changes
Jan 5, 2023
alexanderbez
added
the
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
label
Jan 5, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jan 5, 2023
(cherry picked from commit 465e0f6)
julienrbrt
pushed a commit
that referenced
this pull request
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #11382
The memory leak from #11382 is caused by the
iavl-cache-size
being too large (500 000 by default).HistoricalInfo
objects therefore accumulate in memory over time.There is already a solution added by this PR to change the
iavl-cache-size
. It requires using theserver.DefaultBaseappOptions
, or directly callingbaseapp.SetIAVLCacheSize
when creating the app object, and changing theiavl-cache-size
value inapp.toml
.This PR updates the docs to make it clear that the
iavl-cache-size
parameter is a number of nodes, and not an amount of data.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
docs:
prefix in the PR titleReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
docs:
prefix in the PR title