Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate denom in bank grpc queries #14538

Merged
merged 6 commits into from
Jan 9, 2023
Merged

fix: validate denom in bank grpc queries #14538

merged 6 commits into from
Jan 9, 2023

Conversation

julienrbrt
Copy link
Member

Description

Closes: #14536

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner January 9, 2023 09:29
@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Jan 9, 2023
amaury1093
amaury1093 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

atheeshp
atheeshp approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@atheeshp atheeshp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, a small doubt

x/bank/keeper/grpc_query.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt enabled auto-merge (squash) January 9, 2023 11:35
@julienrbrt
Copy link
Member Author

We've broken GH Actions :D

@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julienrbrt julienrbrt merged commit e9bf5b7 into main Jan 9, 2023
@julienrbrt julienrbrt deleted the julien/validate-denom branch January 9, 2023 14:38
mergify bot pushed a commit that referenced this pull request Jan 9, 2023
@julienrbrt @mergify
fix: validate denom in bank grpc queries (#14538)
c9bdfcd 
(cherry picked from commit e9bf5b7)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jan 9, 2023
Merged
amaury1093 pushed a commit that referenced this pull request Jan 9, 2023
@mergify @julienrbrt
fix: validate denom in bank grpc queries (backport #14538) (#14539)
0301618 
Co-authored-by: Julien Robert <julien@rbrt.fr>
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 approved these changes

@atheeshp atheeshp atheeshp approved these changes

@facundomedica facundomedica facundomedica approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:x/bank
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/bank/keeper: UnmarshalBalanceCompat should firstly validate the denomination to avoid crashes
5 participants
@julienrbrt @amaury1093 @facundomedica @atheeshp @likhita-809