feat: add diff and home command in confix #14568
Conversation
|
[Cosmos SDK - Confix] Kudos, SonarCloud Quality Gate passed!
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // LoadConfig loads and parses the TOML document from path. | ||
| func LoadConfig(path string) (*tomledit.Document, error) { | ||
| f, err := os.Open(path) |
Check failure
Code scanning / gosec
Potential file inclusion via variable
| if err != nil { | ||
| return nil, fmt.Errorf("failed to open %q: %v", path, err) | ||
| } | ||
| defer f.Close() |
Check failure
Code scanning / gosec
Deferring unsafe method "Close" on type "*os.File"
julienrbrt
changed the title
|
|
||
| ```go | ||
| rootCmd.AddCommand( | ||
| confixcmd.ConfigCommand(), |
There was a problem hiding this comment.
if a users adds custom values to the app.toml how will the command know to add them when a migration happens? or does it generate a new config and compare
There was a problem hiding this comment.
Right now, it still only compares to the SDK default against a file, but in #14630 I'll improve the non standalone functionalities. This is a good use case, as I was thinking of only SDK defaults, but comparing app default is probably better. Adding to the issue.
Description
Follow-up of #14342.
Ref: #13661, #11051
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change