-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename snapshot proto package #14597
Conversation
One thing actually, we've changed the package name in 0.48 vs <= 0.47 (3222be3). |
Oh, if we changed package names, then we can remove fields freely in the newly-named package. It's not actually a rename, but basically leaving the old one Also, maybe we can use |
Okay, so I am not re-adding it here, but only rename it to v1 and in v0.47 (where it is not yet renamed, I can add it as deprecated if that is what is wanted) |
CHANGELOG.md
Outdated
@@ -154,6 +154,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|||
### API Breaking Changes | |||
|
|||
* (snapshots) [#14597](https://github.com/cosmos/cosmos-sdk/pull/14597) Move `snapshots` to `store/snapshots` and rename bump proto package to v1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had no changelog for the package moving (I am noticing that we mostly forgot to add a changelog for all store refactors). Precising the renaming as well.
ff2aae2
to
c8e055e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to keep the old one around?
Don't think it's necessary as it isn't used. |
Description
See #14591 (comment)
As per #14597 (comment) this PR renames the package to
v1
but not re-add the fields compared to #14608 (on release/v0.47.x)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change