refactor: remove sdk dep from store #14603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-prbot
requested review from
a team,
julienrbrt and
testinginprod
and removed request for
a team
tac0turtle
changed the title
github-actions
bot
added
C:x/auth
C:x/authz
C:x/bank
C:x/capability
C:x/distribution
tac0turtle
commented
Jan 12, 2023
| @@ -22,7 +21,7 @@ type AppModuleSimulation interface { | |||
| ProposalContents(simState SimulationState) []simulation.WeightedProposalContent | |||
|
|
|||
| // register a func to decode the each module's defined types from their corresponding store key | |||
| RegisterStoreDecoder(storetypes.StoreDecoderRegistry) | |||
There was a problem hiding this comment.
this is interface breaking but I think its acceptable since other wise store has a simulation type for no reason
alexanderbez
approved these changes
Jan 12, 2023
julienrbrt
approved these changes
Jan 12, 2023
likhita-809
approved these changes
Jan 13, 2023
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
|
Same as 14a1f81 needs to be done for |
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change